Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: make WebKit @ MacOS 10.14 error more prominent (#6943)

Browse source 
The new message is much more prominent in the logs:

```
aslushnikov:~/prog/playwright(make-deprecation-error-more-prominent)$ node a.js
node:internal/process/promises:246
          triggerUncaughtException(err, true /* fromPromise */);
          ^

browserType.launch: Protocol error (Playwright.enable): Browser closed.
==================== Browser output: ====================
<launching> /Users/aslushnikov/prog/playwright/browser_patches/deprecated-webkit-mac-10.14/pw_run.sh --inspector-pipe --headless --no-startup-window
<launched> pid=5120
[pid=5120][out] ****************************************************************
[pid=5120][out] ****************************************************************
[pid=5120][out]
[pid=5120][out] ERROR: MacOS version is too old!
[pid=5120][out]
[pid=5120][out] This version of Playwright does not support running
[pid=5120][out] WebKit on MacOS 10.14. Please either:
[pid=5120][out] - update your operating system to version 10.15 or higher
[pid=5120][out] - use Playwright v1.11 or older
[pid=5120][out]
[pid=5120][out] ****************************************************************
[pid=5120][out] ****************************************************************
[pid=5120] <process did exit: exitCode=1, signal=null>
[pid=5120] starting temporary directories cleanup
```
This commit is contained in:
Andrey Lushnikov 2021-06-07 14:23:06 -07:00 committed by GitHub
parent d0eaec368b
commit 15668f04a8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
browser_patches/deprecated-webkit-mac-10.14/BUILD_NUMBER
View file

@ -1,2 +1,2 @@
1445
Changed: lushnikov@chromium.org Thu Jun 3 15:24:06 PDT 2021
1446
Changed: lushnikov@chromium.org Mon Jun 7 14:01:01 PDT 2021

15
browser_patches/deprecated-webkit-mac-10.14/pw_run.sh
View file

@ -1,4 +1,17 @@
#!/bin/bash
echo "ERROR: this version of Playwright does not support running WebKit on MacOS 10.14. Please either update MacOS to 10.15+ or use Playwright@v1.11"
cat << EndOfMessage
****************************************************************
****************************************************************
ERROR: MacOS version is too old!
This version of Playwright does not support running
WebKit on MacOS 10.14. Please either:
- update your operating system to version 10.15 or higher
- use Playwright v1.11 or older
****************************************************************
****************************************************************
EndOfMessage
exit 1;