From 15b92e3f625e8e1aa25f76875893e5d40971d69d Mon Sep 17 00:00:00 2001 From: Dmitry Gozman Date: Thu, 2 Dec 2021 07:44:13 -0800 Subject: [PATCH] test: disable flaky test on wk/ff (#10662) This is a Chromium-specific test, skip it on wk/ff. --- tests/page/page-event-request.spec.ts | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tests/page/page-event-request.spec.ts b/tests/page/page-event-request.spec.ts index d6d4e3ca0b..a76f6b1d95 100644 --- a/tests/page/page-event-request.spec.ts +++ b/tests/page/page-event-request.spec.ts @@ -71,6 +71,8 @@ it('should return response body when Cross-Origin-Opener-Policy is set', async ( }); it('should fire requestfailed when intercepting race', async ({ page, server, browserName }) => { + it.skip(browserName !== 'chromium', 'This test is specifically testing Chromium race'); + const promsie = new Promise(resolve => { let counter = 0; const failures = new Set(); @@ -93,12 +95,6 @@ it('should fire requestfailed when intercepting race', async ({ page, server, br // Stall requests to make sure we don't get requestfinished. await page.route('**', route => {}); - const runFunc = { - chromium: 'abortAll()', // Fast in chromium to expose the race. - webkit: 'setTimeout(abortAll, 0)', // Async in webkit to let it issue requests. - firefox: 'setTimeout(abortAll, 1000)', // Slow in firefox to give it enough time to issue requests. - }[browserName]; - await page.setContent(` @@ -116,7 +112,7 @@ it('should fire requestfailed when intercepting race', async ({ page, server, br for (const frame of frames) frame.src = "about:blank"; } - ${runFunc} + abortAll(); `);