Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat(auth): roll webkit to 1063, make auth work for headful (#387)

Browse source
This commit is contained in:
Pavel Feldman 2020-01-06 16:31:38 -08:00 committed by Yury Semikhatsky
parent 0cc7277053
commit 15ee47c7b2
3 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -10,7 +10,7 @@
"playwright": { "playwright": {
"chromium_revision": "724623", "chromium_revision": "724623",
"firefox_revision": "1009", "firefox_revision": "1009",
"webkit_revision": "1061" "webkit_revision": "1063"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",

2
src/webkit/wkNetworkManager.ts
View file

@ -55,6 +55,8 @@ export class WKNetworkManager {
promises.push(session.send('Network.setEmulateOfflineState', { offline: true })); promises.push(session.send('Network.setEmulateOfflineState', { offline: true }));
if (credentials) if (credentials)
promises.push(session.send('Emulation.setAuthCredentials', { ...credentials })); promises.push(session.send('Emulation.setAuthCredentials', { ...credentials }));
else
promises.push(session.send('Emulation.setAuthCredentials', { username: '', password: '' }));
await Promise.all(promises); await Promise.all(promises);
} }

2
test/interception.spec.js
View file

@ -476,7 +476,7 @@ module.exports.describe = function({testRunner, expect, defaultBrowserOptions, p
}); });
}); });
describe.skip(FFOX || (WEBKIT && process.platform === 'linux'))('Interception.authenticate', function() { describe.skip(FFOX)('Interception.authenticate', function() {
it('should work', async({page, server}) => { it('should work', async({page, server}) => {
server.setAuth('/empty.html', 'user', 'pass'); server.setAuth('/empty.html', 'user', 'pass');
let response = await page.goto(server.EMPTY_PAGE); let response = await page.goto(server.EMPTY_PAGE);