Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove unused botName from types (#30172)

Browse source
This commit is contained in:
Yury Semikhatsky 2024-03-28 16:16:15 -07:00 committed by GitHub
parent 4d8babb27c
commit 16318ea715
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 41 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/html-reporter/src/types.ts
View file

@ -66,7 +66,6 @@ export type TestCaseSummary = {
title: string;
path: string[];
projectName: string;
botName?: string;
location: Location;
annotations: TestCaseAnnotation[];
tags: string[];

3
packages/playwright/src/reporters/merge.ts
View file

@ -381,8 +381,7 @@ class IdsPatcher {
}
private _onProject(project: JsonProject) {
project.metadata = project.metadata ?? {};
project.metadata.botName = this._botName;
project.metadata ??= {};
project.suites.forEach(suite => this._updateTestIds(suite));
}

38
tests/playwright-test/reporter-blob.spec.ts
View file

@ -1198,44 +1198,6 @@ test('support fileName option', async ({ runInlineTest, mergeReports }) => {
expect(reportFiles.sort()).toEqual(['report-one.zip', 'report-two.zip']);
});
test('preserve reportName on projects', async ({ runInlineTest, mergeReports }) => {
const files = (reportName: string) => ({
'echo-reporter.js': `
import fs from 'fs';
class EchoReporter {
onBegin(config, suite) {
const projects = suite.suites.map(s => s.project()).sort((a, b) => a.metadata.botName.localeCompare(b.metadata.botName));
console.log('projectNames: ' + projects.map(p => p.name));
console.log('botNames: ' + projects.map(p => p.metadata.botName));
}
}
module.exports = EchoReporter;
`,
'playwright.config.ts': `
module.exports = {
reporter: [['blob', { fileName: '${reportName}.zip' }]],
projects: [
{ name: 'foo' },
]
};
`,
'a.test.js': `
import { test, expect } from '@playwright/test';
test('math 1 @smoke', async ({}) => {});
`,
});
await runInlineTest(files('first'), undefined, { PWTEST_BOT_NAME: 'first' });
await runInlineTest(files('second'), undefined, { PWTEST_BOT_NAME: 'second', PWTEST_BLOB_DO_NOT_REMOVE: '1' });
const reportDir = test.info().outputPath('blob-report');
const { exitCode, output } = await mergeReports(reportDir, {}, { additionalArgs: ['--reporter', test.info().outputPath('echo-reporter.js')] });
expect(exitCode).toBe(0);
expect(output).toContain(`projectNames: foo,foo`);
expect(output).toContain(`botNames: first,second`);
});
test('keep projects with same name different bot name separate', async ({ runInlineTest, mergeReports, showReport, page }) => {
const files = (reportName: string) => ({
'playwright.config.ts': `