Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: unflake "should not leak recorders" (#33264)

Browse source
This commit is contained in:
Dmitry Gozman 2024-10-24 02:47:34 -07:00 committed by GitHub
parent 487134fbaf
commit 1950bbdc6e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 22 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

33
tests/library/trace-viewer.spec.ts
View file

@ -1415,26 +1415,37 @@ test('should not leak recorders', {
}, async ({ showTraceViewer }) => { }, async ({ showTraceViewer }) => {
const traceViewer = await showTraceViewer([traceFile]); const traceViewer = await showTraceViewer([traceFile]);
const counts = async () => { const aliveCount = async () => {
return await traceViewer.page.evaluate(() => { return await traceViewer.page.evaluate(() => {
const weakSet = (window as any)._weakRecordersForTest || new Set(); const weakSet = (window as any)._weakRecordersForTest || new Set();
const weakList = [...weakSet]; const weakList = [...weakSet];
const aliveList = weakList.filter(r => !!r.deref()); const aliveList = weakList.filter(r => !!r.deref());
return { total: weakList.length, alive: aliveList.length }; return aliveList.length;
}); });
}; };
await traceViewer.snapshotFrame('page.goto'); await expect(traceViewer.snapshotContainer.contentFrame().locator('body')).toContainText(`Hi, I'm frame`);
await traceViewer.snapshotFrame('page.evaluate');
await traceViewer.page.requestGC(); const frame1 = await traceViewer.snapshotFrame('page.goto');
await expect.poll(() => counts()).toEqual({ total: 4, alive: 1 }); await expect(frame1.locator('body')).toContainText('Hello world');
const frame2 = await traceViewer.snapshotFrame('page.evaluate');
await expect(frame2.locator('button')).toBeVisible();
await traceViewer.snapshotFrame('page.setContent');
await traceViewer.snapshotFrame('page.goto');
await traceViewer.snapshotFrame('page.evaluate');
await traceViewer.snapshotFrame('page.setContent');
await traceViewer.page.requestGC(); await traceViewer.page.requestGC();
await expect.poll(() => counts()).toEqual({ total: 8, alive: 1 }); await expect.poll(() => aliveCount()).toBeLessThanOrEqual(2); // two snapshot iframes
const frame3 = await traceViewer.snapshotFrame('page.setViewportSize');
await expect(frame3.locator('body')).toContainText(`Hi, I'm frame`);
const frame4 = await traceViewer.snapshotFrame('page.goto');
await expect(frame4.locator('body')).toContainText('Hello world');
const frame5 = await traceViewer.snapshotFrame('page.evaluate');
await expect(frame5.locator('button')).toBeVisible();
await traceViewer.page.requestGC();
await expect.poll(() => aliveCount()).toBeLessThanOrEqual(2); // two snapshot iframes
}); });
test('should serve css without content-type', async ({ page, runAndTrace, server }) => { test('should serve css without content-type', async ({ page, runAndTrace, server }) => {