diff --git a/packages/playwright/src/worker/testTracing.ts b/packages/playwright/src/worker/testTracing.ts index 686c376fb3..e154d6a649 100644 --- a/packages/playwright/src/worker/testTracing.ts +++ b/packages/playwright/src/worker/testTracing.ts @@ -58,7 +58,6 @@ export class TestTracing { wallTime: Date.now(), monotonicTime: monotonicTime(), sdkLanguage: 'javascript', - contextId: '', }; this._appendTraceEvent(this._contextCreatedEvent); } diff --git a/packages/trace-viewer/src/sw/traceModernizer.ts b/packages/trace-viewer/src/sw/traceModernizer.ts index d8e4693de6..16bf3ad2db 100644 --- a/packages/trace-viewer/src/sw/traceModernizer.ts +++ b/packages/trace-viewer/src/sw/traceModernizer.ts @@ -92,7 +92,7 @@ export class TraceModernizer { contextEntry.sdkLanguage = event.sdkLanguage; contextEntry.options = event.options; contextEntry.testIdAttributeName = event.testIdAttributeName; - contextEntry.contextId = event.contextId; + contextEntry.contextId = event.contextId ?? ''; break; } case 'screencast-frame': { diff --git a/packages/trace/src/trace.ts b/packages/trace/src/trace.ts index 3bf508ab97..65843de1ec 100644 --- a/packages/trace/src/trace.ts +++ b/packages/trace/src/trace.ts @@ -44,7 +44,7 @@ export type ContextCreatedTraceEvent = { options: BrowserContextEventOptions, sdkLanguage?: Language, testIdAttributeName?: string, - contextId: string, + contextId?: string, }; export type ScreencastFrameTraceEvent = {