Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix: make launch options in ffPlaywright optional (#637)

Browse source
This commit is contained in:
André Abreu 2020-01-24 21:27:49 +00:00 committed by Andrey Lushnikov
parent 834698ca6b
commit 199d094c6d
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/ffPlaywright.ts
View file

@ -63,7 +63,7 @@ export class FFPlaywright implements Playwright {
this._revision = preferredRevision; this._revision = preferredRevision;
} }
async launch(options: LaunchOptions): Promise<FFBrowser> { async launch(options?: LaunchOptions): Promise<FFBrowser> {
const app = await this.launchBrowserApp(options); const app = await this.launchBrowserApp(options);
const browser = await FFBrowser.connect(app.connectOptions()); const browser = await FFBrowser.connect(app.connectOptions());
// Hack: for typical launch scenario, ensure that close waits for actual process termination. // Hack: for typical launch scenario, ensure that close waits for actual process termination.