Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

tests(ff): uncomment a couple of firefox tests (#1465)

Browse source
This commit is contained in:
Pavel Feldman 2020-03-21 17:58:33 -07:00 committed by GitHub
parent 9e9584441c
commit 1b08797c6f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/firefox/ffBrowser.ts
View file

@ -75,13 +75,11 @@ export class FFBrowser extends platform.EventEmitter implements Browser {
// TODO: remove isMobile/hasTouch from the protocol?
if (options.isMobile)
throw new Error('options.isMobile is not supported in Firefox');
if (options.hasTouch)
throw new Error('options.hasTouch is not supported in Firefox');
viewport = {
viewportSize: { width: options.viewport.width, height: options.viewport.height },
deviceScaleFactor: options.deviceScaleFactor || 1,
isMobile: false,
hasTouch: false,
hasTouch: !!options.hasTouch,
};
} else if (options.viewport !== null) {
viewport = {

5
test/click.spec.js
View file

@ -228,9 +228,10 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI
await page.click('label[for="agree"]');
expect(await page.evaluate(() => result.check)).toBe(false);
});
it.skip(FFOX)('should not hang with touch-enabled viewports', async({server, browser}) => {
it('should not hang with touch-enabled viewports', async({server, browser}) => {
// @see https://github.com/GoogleChrome/puppeteer/issues/161
const context = await browser.newContext({ viewport: playwright.devices['iPhone 6'].viewport });
const { viewport, hasTouch } = playwright.devices['iPhone 6'];
const context = await browser.newContext({ viewport, hasTouch });
const page = await context.newPage();
await page.mouse.down();
await page.mouse.move(100, 10);

2
test/popup.spec.js
View file

@ -114,7 +114,7 @@ module.exports.describe = function({testRunner, expect, playwright, CHROMIUM, WE
expect(await popup.title()).toBe('Woof-Woof');
await context.close();
});
it.skip(FFOX)('should inherit touch support from browser context', async function({browser, server}) {
it('should inherit touch support from browser context', async function({browser, server}) {
const context = await browser.newContext({
viewport: { width: 400, height: 500 },
hasTouch: true