From 1b1da1c07524c522d2c3c2981cd660b577d0bb1f Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Tue, 17 Dec 2024 10:42:29 +0100 Subject: [PATCH] don't copy screenshot file --- packages/playwright/src/index.ts | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/packages/playwright/src/index.ts b/packages/playwright/src/index.ts index 1e70bfc151..9680f3bcf7 100644 --- a/packages/playwright/src/index.ts +++ b/packages/playwright/src/index.ts @@ -638,7 +638,7 @@ class ArtifactsRecorder { try { const screenshotPath = this._createScreenshotAttachmentPath(); await fs.promises.rename(file, screenshotPath); - await this._attachScreenshot(screenshotPath); + this._attachScreenshot(screenshotPath); } catch { } } @@ -665,14 +665,19 @@ class ArtifactsRecorder { if (temporary) this._temporaryScreenshots.push(screenshotPath); else - await this._attachScreenshot(screenshotPath); + this._attachScreenshot(screenshotPath); } catch { // Screenshot may fail, just ignore. } } - private async _attachScreenshot(screenshotPath: string) { - await this._testInfo.attach('screenshot', { path: screenshotPath, contentType: 'image/png' }); + private _attachScreenshot(screenshotPath: string) { + const step = this._testInfo._addStep({ + title: `attach "screenshot"`, + category: 'attach', + }); + step.attachments.push({ name: 'screenshot', path: screenshotPath, contentType: 'image/png' }); + step.complete({}); } private async _screenshotOnTestFailure() {