Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(webkit): deduce response mime type from content-type (#9264)

Browse source
This commit is contained in:
Yury Semikhatsky 2021-10-01 13:04:03 -07:00 committed by GitHub
parent 235eaca34a
commit 1b4adfb916
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/server/webkit/wkInterceptableRequest.ts
View file

@ -130,7 +130,7 @@ export class WKRouteImpl implements network.RouteDelegate {
// In certain cases, protocol will return error if the request was already canceled // In certain cases, protocol will return error if the request was already canceled
// or the page was closed. We should tolerate these errors. // or the page was closed. We should tolerate these errors.
let mimeType = response.isBase64 ? 'application/octet-stream' : 'text/plain'; let mimeType = response.isBase64 ? 'application/octet-stream' : 'text/plain';
const headers = headersArrayToObject(response.headers, false /* lowerCase */); const headers = headersArrayToObject(response.headers, true /* lowerCase */);
const contentType = headers['content-type']; const contentType = headers['content-type'];
if (contentType) if (contentType)
mimeType = contentType.split(';')[0].trim(); mimeType = contentType.split(';')[0].trim();

2
tests/page/page-request-fulfill.spec.ts
View file

@ -225,7 +225,7 @@ it('should fulfill with fetch result and overrides', async ({ page, server, isEl
response, response,
status: 201, status: 201,
headers: { headers: {
...response.headers(), 'Content-Type': 'application/json', // Case matters for the tested behavior
'foo': 'bar' 'foo': 'bar'
} }
}); });