From 1cb4bebdbbf4b6411056ac2d14ced1be7c0e4d4a Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Wed, 23 Oct 2024 13:18:48 +0200 Subject: [PATCH] hardcode devserver port --- .../src/server/trace/viewer/traceViewer.ts | 10 +++++----- utils/build/build.js | 4 ++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts index 11d446b042..4704541b98 100644 --- a/packages/playwright-core/src/server/trace/viewer/traceViewer.ts +++ b/packages/playwright-core/src/server/trace/viewer/traceViewer.ts @@ -125,12 +125,12 @@ export async function installRootRedirect(server: HttpServer, traceUrls: string[ for (const reporter of options.reporter || []) params.append('reporter', reporter); - let urlPath = `./trace/${options.webApp || 'index.html'}?${params.toString()}`; - - if (process.env.PW_WEB_DEV_SERVER) { - params.append('testServerPort', '' + server.port()); - urlPath = `http://localhost:${process.env.PW_WEB_DEV_SERVER}/${options.webApp || 'index.html'}?${params.toString()}`; + let baseUrl = './trace/'; + if (process.env.PW_HMR === '1') { + params.set('testServerPort', '' + server.port()); + baseUrl = 'http://localhost:44223/'; } + const urlPath = `${baseUrl}${options.webApp || 'index.html'}?${params.toString()}`; server.routePath('/', (_, response) => { response.statusCode = 302; diff --git a/utils/build/build.js b/utils/build/build.js index 0f32f05df7..b9b9d0a70e 100644 --- a/utils/build/build.js +++ b/utils/build/build.js @@ -307,10 +307,10 @@ steps.push({ }); // web packages dev server -if (process.env.PW_WEB_DEV_SERVER) { +if (watchMode) { steps.push({ command: 'npx', - args: ['vite', '--port', process.env.PW_WEB_DEV_SERVER], + args: ['vite', '--port', '44223'], shell: true, cwd: path.join(__dirname, '..', '..', 'packages', 'trace-viewer'), concurrent: true,