Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

tests(webkit): mark Page.navigate to invalid URL test as passing (#293)

Browse source
This commit is contained in:
Yury Semikhatsky 2019-12-18 16:49:43 -07:00 committed by GitHub
parent ac2ea265fe
commit 1d4ebd37b1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
package.json
View file

@ -10,7 +10,7 @@
"playwright": { "playwright": {
"chromium_revision": "724623", "chromium_revision": "724623",
"firefox_revision": "1008", "firefox_revision": "1008",
"webkit_revision": "1044" "webkit_revision": "1046"
}, },
"scripts": { "scripts": {
"unit": "node test/test.js", "unit": "node test/test.js",

6
test/navigation.spec.js
View file

@ -141,10 +141,9 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
const response = await page.goto(server.EMPTY_PAGE, {waitUntil: 'networkidle2'}); const response = await page.goto(server.EMPTY_PAGE, {waitUntil: 'networkidle2'});
expect(response.status()).toBe(200); expect(response.status()).toBe(200);
}); });
it.skip(WEBKIT)('should fail when navigating to bad url', async({page, server}) => { it('should fail when navigating to bad url', async({page, server}) => {
let error = null; let error = null;
await page.goto('asdfasdf').catch(e => error = e); await page.goto('asdfasdf').catch(e => error = e);
// FIXME: shows dialog in WebKit.
if (CHROME || WEBKIT) if (CHROME || WEBKIT)
expect(error.message).toContain('Cannot navigate to invalid URL'); expect(error.message).toContain('Cannot navigate to invalid URL');
else else
@ -361,8 +360,7 @@ module.exports.addTests = function({testRunner, expect, playwright, FFOX, CHROME
process.removeListener('warning', warningHandler); process.removeListener('warning', warningHandler);
expect(warning).toBe(null); expect(warning).toBe(null);
}); });
it.skip(WEBKIT)('should not leak listeners during bad navigation', async({page, server}) => { it('should not leak listeners during bad navigation', async({page, server}) => {
// FIXME: shows dialog in webkit.
let warning = null; let warning = null;
const warningHandler = w => warning = w; const warningHandler = w => warning = w;
process.on('warning', warningHandler); process.on('warning', warningHandler);