Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(inspect): highlight on explore input change (#5726)

Browse source
This commit is contained in:
Pavel Feldman 2021-03-09 07:44:10 -08:00 committed by GitHub
parent d311058245
commit 1d6feb2ab8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/server/supplements/recorderSupplement.ts
View file

@ -204,7 +204,7 @@ export class RecorderSupplement {
await this._context.exposeBinding('_playwrightRecorderState', false, source => {
let snapshotUrl: string | undefined;
let actionSelector: string | undefined;
let actionSelector = this._highlightedSelector;
let actionPoint: Point | undefined;
if (this._hoveredSnapshot) {
const metadata = this._allMetadatas.get(this._hoveredSnapshot.callLogId)!;
@ -214,7 +214,7 @@ export class RecorderSupplement {
for (const [metadata, sdkObject] of this._currentCallsMetadata) {
if (source.page === sdkObject.attribution.page) {
actionPoint = metadata.point || actionPoint;
actionSelector = metadata.params.selector || actionSelector;
actionSelector = actionSelector || metadata.params.selector;
}
}
}

18
test/pause.spec.ts
View file

@ -270,6 +270,24 @@ describe('pause', (suite, { mode }) => {
await recorderPage.click('[title=Resume]');
await scriptPromise;
});
it('should highlight on explore', async ({ page, recorderPageGetter }) => {
await page.setContent('<button>Submit</button>');
const scriptPromise = (async () => {
await page.pause();
})();
const recorderPage = await recorderPageGetter();
const [element] = await Promise.all([
page.waitForSelector('x-pw-highlight:visible'),
recorderPage.fill('input[placeholder="Playwright Selector"]', 'text=Submit'),
]);
const button = await page.$('text=Submit');
const box1 = await element.boundingBox();
const box2 = await button.boundingBox();
expect(box1).toEqual(box2);
await recorderPage.click('[title=Resume]');
await scriptPromise;
});
});
async function sanitizeLog(recorderPage: Page): Promise<string[]> {