Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(windows): show details about missing dependencies (#3839)

Browse source
This commit is contained in:
Philipp Mudra 2020-09-11 01:36:08 +02:00 committed by GitHub
parent 3495842e7f
commit 1e600cb9d8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/server/validateDependencies.ts
View file

@ -88,6 +88,9 @@ async function validateDependenciesWindows(browserPath: string, browser: Browser
`as Administrator:`,
``,
` Install-WindowsFeature Server-Media-Foundation`,
``,
`For Windows N editions visit:`,
`https://support.microsoft.com/en-us/help/3145500/media-feature-pack-list-for-windows-n-editions`,
``);
}
@ -200,7 +203,7 @@ async function missingFileDependenciesWindows(filePath: string): Promise<Array<s
});
if (code !== 0)
return [];
const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim());
const missingDeps = stdout.split('\n').map(line => line.trim()).filter(line => line.endsWith('not found') && line.includes('=>')).map(line => line.split('=>')[0].trim().toLowerCase());
return missingDeps;
}