From 1ee2d01f1c0dcee8f52ce8c12ea1ad9750316f66 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Tue, 21 Dec 2021 17:31:13 -0800 Subject: [PATCH] test: unflake page-click.spec.ts test (#11050) --- tests/page/page-click.spec.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/page/page-click.spec.ts b/tests/page/page-click.spec.ts index 0b6d837493..90382e2d57 100644 --- a/tests/page/page-click.spec.ts +++ b/tests/page/page-click.spec.ts @@ -834,11 +834,14 @@ it('should not hang when frame is detached', async ({ page, server, mode }) => { button.style.marginLeft = '200px'; }); - let detachPromise; + let resolveDetachPromise; + const detachPromise = new Promise(resolve => resolveDetachPromise = resolve); const __testHookBeforeStable = () => { // Detach the frame after "waiting for stable" has started. - setTimeout(() => { - detachPromise = detachFrame(page, 'frame1'); + + setTimeout(async () => { + await detachFrame(page, 'frame1'); + resolveDetachPromise(); }, 1000); }; const promise = frame.click('button', { __testHookBeforeStable } as any).catch(e => e);