Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(to-have-screenshot): show number of bad pixels in mismatched error (#12502)

Browse source 
Drive-by: do not show empty call log.

References #12441
This commit is contained in:
Andrey Lushnikov 2022-03-04 12:01:05 -07:00 committed by GitHub
parent f96a1a3ccd
commit 1f5cfcaeec
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/playwright-core/src/utils/comparators.ts
View file

@ -66,7 +66,11 @@ function compareImages(mimeType: string, actualBuffer: Buffer | string, expected
maxDiffPixels = Math.min(maxDiffPixels1, maxDiffPixels2); maxDiffPixels = Math.min(maxDiffPixels1, maxDiffPixels2);
else else
maxDiffPixels = maxDiffPixels1 ?? maxDiffPixels2 ?? 0; maxDiffPixels = maxDiffPixels1 ?? maxDiffPixels2 ?? 0;
return count > maxDiffPixels ? { diff: PNG.sync.write(diff) } : null; const ratio = count / (expected.width * expected.height);
return count > maxDiffPixels ? {
errorMessage: `${count} pixels (ratio ${ratio.toFixed(2)} of all image pixels) are different`,
diff: PNG.sync.write(diff),
} : null;
} }
function compareText(actual: Buffer | string, expectedBuffer: Buffer): ComparatorResult { function compareText(actual: Buffer | string, expectedBuffer: Buffer): ComparatorResult {

2
packages/playwright-test/src/matchers/toMatchSnapshot.ts
View file

@ -179,7 +179,7 @@ class SnapshotHelper<T extends ImageComparatorOptions> {
'', '',
]); ]);
} }
if (log) if (log?.length)
output.push(callLogText(log)); output.push(callLogText(log));
if (expected !== undefined) { if (expected !== undefined) {

4
tests/playwright-test/to-have-screenshot.spec.ts
View file

@ -254,8 +254,10 @@ test('should fail when screenshot is different pixels', async ({ runInlineTest }
` `
}); });
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
expect(result.output).toContain('Timeout 2000ms exceeded');
expect(result.output).toContain('Screenshot comparison failed'); expect(result.output).toContain('Screenshot comparison failed');
expect(result.output).toContain('921600 pixels');
expect(result.output).not.toContain('Call log');
expect(result.output).toContain('ratio 1.00');
expect(result.output).toContain('Expected:'); expect(result.output).toContain('Expected:');
expect(result.output).toContain('Received:'); expect(result.output).toContain('Received:');
}); });