Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

continue using close

Browse source
This commit is contained in:
Simon Knott 2025-01-13 11:17:43 +01:00
parent 25494cb53e
commit 2224fd2bf9
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-core/src/server/registry/oopDownloadBrowserMain.ts
View file

@ -14,6 +14,7 @@
* limitations under the License. * limitations under the License.
*/ */
import type { WriteStream } from 'fs';
import fs from 'fs'; import fs from 'fs';
import path from 'path'; import path from 'path';
import { httpRequest } from '../../utils/network'; import { httpRequest } from '../../utils/network';
@ -46,7 +47,7 @@ function browserDirectoryToMarkerFilePath(browserDirectory: string): string {
return path.join(browserDirectory, 'INSTALLATION_COMPLETE'); return path.join(browserDirectory, 'INSTALLATION_COMPLETE');
} }
function downloadFile(options: DownloadParams, file: Writable): Promise<void> { function downloadFile(options: DownloadParams, file: WriteStream | Writable): Promise<void> {
let downloadedBytes = 0; let downloadedBytes = 0;
let totalBytes = 0; let totalBytes = 0;
@ -89,7 +90,10 @@ function downloadFile(options: DownloadParams, file: Writable): Promise<void> {
response.pipe(file); response.pipe(file);
response.on('data', onData); response.on('data', onData);
response.on('error', (error: any) => { response.on('error', (error: any) => {
file.destroy(); if ('close' in file)
file.close();
else
file.destroy(error);
if (error?.code === 'ECONNRESET') { if (error?.code === 'ECONNRESET') {
log(`-- download failed, server closed connection`); log(`-- download failed, server closed connection`);
promise.reject(new Error(`Download failed: server closed connection. URL: ${options.url}`)); promise.reject(new Error(`Download failed: server closed connection. URL: ${options.url}`));