Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(wk websocket): do not send messages to a closing websocket (#593)

Browse source
This commit is contained in:
Dmitry Gozman 2020-01-23 10:33:05 -08:00 committed by GitHub
parent 5a67d780e5
commit 24f5f1f952
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/server/wkPlaywright.ts
View file

@ -283,7 +283,12 @@ function wrapTransportWithWebSocket(transport: ConnectionTransport) {
} }
socket = s; socket = s;
s.on('message', message => transport.send(Buffer.from(message).toString())); s.on('message', message => transport.send(Buffer.from(message).toString()));
transport.onmessage = message => s.send(message); transport.onmessage = message => {
// We are not notified when socket starts closing, and sending messages to a closing
// socket throws an error.
if (s.readyState !== ws.CLOSING)
s.send(message);
};
s.on('close', () => { s.on('close', () => {
socket = undefined; socket = undefined;
transport.onmessage = undefined; transport.onmessage = undefined;