From 2505d48b3289377112fe6ff2a7be78bf578da4d6 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Wed, 31 May 2023 10:52:29 -0700
Subject: [PATCH] test: skip and unflake tests (#23399)

- `should respect tracesDir and name` does not work with service mode;
- `isVisible during navigation should not throw` had a short timeout.
---
 tests/library/tracing.spec.ts         | 4 +++-
 tests/page/locator-is-visible.spec.ts | 4 +---
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/library/tracing.spec.ts b/tests/library/tracing.spec.ts
index 6c125da67c..a15f5f905c 100644
--- a/tests/library/tracing.spec.ts
+++ b/tests/library/tracing.spec.ts
@@ -182,7 +182,9 @@ test('should collect two traces', async ({ context, page, server }, testInfo) =>
   }
 });
 
-test('should respect tracesDir and name', async ({ browserType, server }, testInfo) => {
+test('should respect tracesDir and name', async ({ browserType, server, mode }, testInfo) => {
+  test.skip(mode === 'service', 'Service ignores tracesDir');
+
   const tracesDir = testInfo.outputPath('traces');
   const browser = await browserType.launch({ tracesDir });
   const context = await browser.newContext();
diff --git a/tests/page/locator-is-visible.spec.ts b/tests/page/locator-is-visible.spec.ts
index e4203a0f5f..cbce1026b6 100644
--- a/tests/page/locator-is-visible.spec.ts
+++ b/tests/page/locator-is-visible.spec.ts
@@ -88,15 +88,13 @@ it('isVisible inside a role=button', async ({ page }) => {
 
 it('isVisible during navigation should not throw', async ({ page, server }) => {
   for (let i = 0; i < 20; i++) {
-    // Make sure previous navigation finishes, to avoid page.setContent throwing.
-    await page.waitForTimeout(100);
     await page.setContent(`
       <script>
         setTimeout(() => {
           window.location.href = ${JSON.stringify(server.EMPTY_PAGE)};
         }, Math.random(50));
       </script>
-    `);
+    `).catch(() => {});  // Avoid page.setContent throwing becuase of scheduled navigation.
     expect(await page.locator('div').isVisible()).toBe(false);
   }
 });