Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(recorder): do not ignore signals except for navigation

Browse source 
When a signal arrives late enough, after the last action
was committed in 5 seconds, we should still account for it.
This includes downloads, popups and dialogs, but not navigations.

Exposed by a flaky test "should record open in a new tab with url".
This commit is contained in:
Dmitry Gozman 2024-05-23 17:10:00 -07:00
parent b12cfe457b
commit 262d72b32f
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/recorder/codeGenerator.ts
View file

@ -130,7 +130,8 @@ export class CodeGenerator extends EventEmitter {
this._currentAction.action.signals.push(signal);
return;
}
if (this._lastAction && !this._lastAction.committed) {
if (this._lastAction && (!this._lastAction.committed || signal.name !== 'navigation')) {
const signals = this._lastAction.action.signals;
if (signal.name === 'navigation' && signals.length && signals[signals.length - 1].name === 'download')
return;