From 27403dcbb4eb1387697b3586bb55704a255845d3 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Wed, 17 May 2023 14:32:38 -0700 Subject: [PATCH] devops: remove explicit npm@8 installation (#23096) Node 16+ comes with npm 8+ by default. --- .github/workflows/tests_primary.yml | 16 +++------------ .github/workflows/tests_secondary.yml | 28 --------------------------- 2 files changed, 3 insertions(+), 41 deletions(-) diff --git a/.github/workflows/tests_primary.yml b/.github/workflows/tests_primary.yml index e6dc1bee66..be3c869787 100644 --- a/.github/workflows/tests_primary.yml +++ b/.github/workflows/tests_primary.yml @@ -33,11 +33,8 @@ jobs: matrix: browser: [chromium, firefox, webkit] os: [ubuntu-22.04] - node-version: [14] + node-version: [16] include: - - os: ubuntu-22.04 - node-version: 16 - browser: chromium - os: ubuntu-22.04 node-version: 18 browser: chromium @@ -47,7 +44,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node-version }} - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -108,7 +104,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -148,7 +143,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{matrix.node-version}} - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -204,7 +198,6 @@ jobs: with: # Component tests require Node.js 16+ (they require ESM via TS) node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -215,7 +208,7 @@ jobs: if: always() test-package-installations: - name: "Installation Test ${{ matrix.os }} (${{ matrix.node_version }})" + name: "Installation Test ${{ matrix.os }}" runs-on: ${{ matrix.os }} strategy: fail-fast: false @@ -224,15 +217,12 @@ jobs: - ubuntu-latest - macos-latest - windows-latest - node_version: - - "^14.1.0" # pre 14.1, zip extraction was broken (https://github.com/microsoft/playwright/issues/1988) timeout-minutes: 30 steps: - uses: actions/checkout@v3 - uses: actions/setup-node@v3 with: - node-version: ${{ matrix.node_version }} - - run: npm i -g npm@8 + node-version: 16 - run: npm ci env: DEBUG: pw:install diff --git a/.github/workflows/tests_secondary.yml b/.github/workflows/tests_secondary.yml index 47722a880f..e0de056900 100644 --- a/.github/workflows/tests_secondary.yml +++ b/.github/workflows/tests_secondary.yml @@ -34,7 +34,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -65,7 +64,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -94,7 +92,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -129,7 +126,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: ${{ matrix.node_version }} - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -156,7 +152,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -188,7 +183,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -224,7 +218,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: DEBUG: pw:install @@ -247,7 +240,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -273,7 +265,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -300,7 +291,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -330,7 +320,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -365,7 +354,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -396,7 +384,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -422,7 +409,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -449,7 +435,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -475,7 +460,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -502,7 +486,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -529,7 +512,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -555,7 +537,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -581,7 +562,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -608,7 +588,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -634,7 +613,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -660,7 +638,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -687,7 +664,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -713,7 +689,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -739,7 +714,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -766,7 +740,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci env: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 @@ -792,7 +765,6 @@ jobs: - uses: actions/setup-node@v3 with: node-version: 16 - - run: npm i -g npm@8 - run: npm ci - run: npm run build - run: npx playwright install-deps