Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Revert "chore: enforce tags format via typescript types (#32384)"

Browse source 
This reverts commit 90e7b9ebac.
This commit is contained in:
Yury Semikhatsky 2024-09-03 09:51:30 -07:00
parent 9f466a1ead
commit 27c9a639ad
3 changed files with 2 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright/types/test.d.ts vendored
View file

@ -1825,10 +1825,8 @@ type TestDetailsAnnotation = {
description?: string;
};
type TestDetailsTag = `@${string}`;
export type TestDetails = {
tag?: TestDetailsTag | TestDetailsTag[];
tag?: string | string[];
annotation?: TestDetailsAnnotation | TestDetailsAnnotation[];
}

12
tests/playwright-test/test-tag.spec.ts
View file

@ -147,18 +147,6 @@ test('should enforce @ symbol', async ({ runInlineTest }) => {
expect(result.output).toContain(`Error: Tag must start with "@" symbol, got "foo" instead.`);
});
test('types should enforce @ symbol', async ({ runTSC }) => {
const result = await runTSC({
'stdio.spec.ts': `
import { test, expect } from '@playwright/test';
test('test1', { tag: 'foo' }, () => {
});
`
});
expect(result.exitCode).toBe(2);
expect(result.output).toContain('error TS2322: Type \'"foo"\' is not assignable to type \'`@${string}` | `@${string}`[] | undefined');
});
test('should be included in testInfo', async ({ runInlineTest }, testInfo) => {
const result = await runInlineTest({
'a.test.ts': `

4
utils/generate_types/overrides-test.d.ts vendored
View file

@ -70,10 +70,8 @@ type TestDetailsAnnotation = {
description?: string;
};
type TestDetailsTag = `@${string}`;
export type TestDetails = {
tag?: TestDetailsTag | TestDetailsTag[];
tag?: string | string[];
annotation?: TestDetailsAnnotation | TestDetailsAnnotation[];
}