Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

refactor: remove useless constant

Browse source
This commit is contained in:
Simon Knott 2024-10-21 15:23:04 +02:00
parent 014577d345
commit 2855f612be
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-core/src/utils/isomorphic/locatorGenerators.ts
View file

@ -163,14 +163,12 @@ function innerAsLocators(factory: LocatorFactory, parsed: ParsedSelector, isFram
continue; continue;
} }
let locatorType: LocatorType = 'default';
const nextPart = parts[index + 1]; const nextPart = parts[index + 1];
const selectorPart = stringifySelector({ parts: [part] }); const selectorPart = stringifySelector({ parts: [part] });
const locatorPart = factory.generateLocator(base, locatorType, selectorPart); const locatorPart = factory.generateLocator(base, 'default', selectorPart);
if (locatorType === 'default' && nextPart && ['internal:has-text', 'internal:has-not-text'].includes(nextPart.name)) { if (nextPart && ['internal:has-text', 'internal:has-not-text'].includes(nextPart.name)) {
const { exact, text } = detectExact(nextPart.body as string); const { exact, text } = detectExact(nextPart.body as string);
// There is no locator equivalent for strict has-text and has-not-text, leave it as is. // There is no locator equivalent for strict has-text and has-not-text, leave it as is.
if (!exact) { if (!exact) {
@ -194,7 +192,7 @@ function innerAsLocators(factory: LocatorFactory, parsed: ParsedSelector, isFram
let locatorPartWithEngine: string | undefined; let locatorPartWithEngine: string | undefined;
if (['xpath', 'css'].includes(part.name)) { if (['xpath', 'css'].includes(part.name)) {
const selectorPart = stringifySelector({ parts: [part] }, /* forceEngineName */ true); const selectorPart = stringifySelector({ parts: [part] }, /* forceEngineName */ true);
locatorPartWithEngine = factory.generateLocator(base, locatorType, selectorPart); locatorPartWithEngine = factory.generateLocator(base, 'default', selectorPart);
} }
tokens.push([locatorPart, locatorPartWithEngine].filter(Boolean) as string[]); tokens.push([locatorPart, locatorPartWithEngine].filter(Boolean) as string[]);