Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test(remove-cookie): do not rely on external websites for tests (#29811)

Browse source 
Fixes https://github.com/microsoft/playwright/issues/29795
This commit is contained in:
Max Schmitt 2024-03-04 23:49:12 +01:00 committed by GitHub
parent 73ffaf65d7
commit 291567b922
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 44 additions and 44 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

88
tests/library/browsercontext-remove-cookies.spec.ts
View file

@ -21,17 +21,17 @@ it('should remove cookies by name', async ({ context, page, server }) => {
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
} }
]); ]);
await page.goto('https://www.example.com'); await page.goto(server.PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie2=2');
await context.removeCookies({ name: 'cookie1' }); await context.removeCookies({ name: 'cookie1' });
expect(await page.evaluate('document.cookie')).toBe('cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie2=2');
@ -41,23 +41,23 @@ it('should remove cookies by domain', async ({ context, page, server }) => {
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.org', domain: new URL(server.CROSS_PROCESS_PREFIX).hostname,
path: '/', path: '/',
} }
]); ]);
await page.goto('https://www.example.com'); await page.goto(server.PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
await page.goto('https://www.example.org'); await page.goto(server.CROSS_PROCESS_PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie2=2');
await context.removeCookies({ domain: 'www.example.org' }); await context.removeCookies({ domain: new URL(server.CROSS_PROCESS_PREFIX).hostname });
expect(await page.evaluate('document.cookie')).toBe(''); expect(await page.evaluate('document.cookie')).toBe('');
await page.goto('https://www.example.com'); await page.goto(server.PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
}); });
@ -65,29 +65,29 @@ it('should remove cookies by path', async ({ context, page, server }) => {
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v2', path: '/api/v2',
}, },
{ {
name: 'cookie3', name: 'cookie3',
value: '3', value: '3',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
} }
]); ]);
await page.goto('https://www.example.com/api/v1'); await page.goto(server.PREFIX + '/api/v1');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3');
await context.removeCookies({ path: '/api/v1' }); await context.removeCookies({ path: '/api/v1' });
expect(await page.evaluate('document.cookie')).toBe('cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie3=3');
await page.goto('https://www.example.com/api/v2'); await page.goto(server.PREFIX + '/api/v2');
expect(await page.evaluate('document.cookie')).toBe('cookie2=2; cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie2=2; cookie3=3');
await page.goto('https://www.example.com/'); await page.goto(server.PREFIX + '/');
expect(await page.evaluate('document.cookie')).toBe('cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie3=3');
}); });
@ -95,21 +95,21 @@ it('should remove cookies by name and domain', async ({ context, page, server })
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
}, },
{ {
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.org', domain: new URL(server.CROSS_PROCESS_PREFIX).hostname,
path: '/', path: '/',
} }
]); ]);
await page.goto('https://www.example.com'); await page.goto(server.PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
await context.removeCookies({ name: 'cookie1', domain: 'www.example.com' }); await context.removeCookies({ name: 'cookie1', domain: new URL(server.PREFIX).hostname });
expect(await page.evaluate('document.cookie')).toBe(''); expect(await page.evaluate('document.cookie')).toBe('');
await page.goto('https://www.example.org'); await page.goto(server.CROSS_PROCESS_PREFIX);
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
}); });
@ -117,29 +117,29 @@ it('should remove cookies by name and path', async ({ context, page, server }) =
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
{ {
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v2', path: '/api/v2',
}, },
{ {
name: 'cookie3', name: 'cookie3',
value: '3', value: '3',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
} }
]); ]);
await page.goto('https://www.example.com/api/v1'); await page.goto(server.PREFIX + '/api/v1');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3');
await context.removeCookies({ name: 'cookie1', path: '/api/v1' }); await context.removeCookies({ name: 'cookie1', path: '/api/v1' });
expect(await page.evaluate('document.cookie')).toBe('cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie3=3');
await page.goto('https://www.example.com/api/v2'); await page.goto(server.PREFIX + '/api/v2');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie3=3');
await page.goto('https://www.example.com/'); await page.goto(server.PREFIX + '/');
expect(await page.evaluate('document.cookie')).toBe('cookie3=3'); expect(await page.evaluate('document.cookie')).toBe('cookie3=3');
}); });
@ -147,35 +147,35 @@ it('should remove cookies by domain and path', async ({ context, page, server })
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v2', path: '/api/v2',
}, },
{ {
name: 'cookie3', name: 'cookie3',
value: '3', value: '3',
domain: 'www.example.org', domain: new URL(server.CROSS_PROCESS_PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
{ {
name: 'cookie4', name: 'cookie4',
value: '4', value: '4',
domain: 'www.example.org', domain: new URL(server.CROSS_PROCESS_PREFIX).hostname,
path: '/api/v2', path: '/api/v2',
} }
]); ]);
await page.goto('https://www.example.com/api/v1'); await page.goto(server.PREFIX + '/api/v1');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
await context.removeCookies({ domain: 'www.example.com', path: '/api/v1' }); await context.removeCookies({ domain: new URL(server.PREFIX).hostname, path: '/api/v1' });
expect(await page.evaluate('document.cookie')).toBe(''); expect(await page.evaluate('document.cookie')).toBe('');
await page.goto('https://www.example.com/api/v2'); await page.goto(server.PREFIX + '/api/v2');
expect(await page.evaluate('document.cookie')).toBe('cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie2=2');
await page.goto('https://www.example.org/api/v2'); await page.goto(server.CROSS_PROCESS_PREFIX + '/api/v2');
expect(await page.evaluate('document.cookie')).toBe('cookie4=4'); expect(await page.evaluate('document.cookie')).toBe('cookie4=4');
}); });
@ -183,29 +183,29 @@ it('should remove cookies by name, domain and path', async ({ context, page, ser
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/api/v2', path: '/api/v2',
}, },
{ {
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.org', domain: new URL(server.CROSS_PROCESS_PREFIX).hostname,
path: '/api/v1', path: '/api/v1',
}, },
]); ]);
await page.goto('https://www.example.com/api/v1'); await page.goto(server.PREFIX + '/api/v1');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
await context.removeCookies({ name: 'cookie1', domain: 'www.example.com', path: '/api/v1' }); await context.removeCookies({ name: 'cookie1', domain: new URL(server.PREFIX).hostname, path: '/api/v1' });
expect(await page.evaluate('document.cookie')).toBe(''); expect(await page.evaluate('document.cookie')).toBe('');
await page.goto('https://www.example.com/api/v2'); await page.goto(server.PREFIX + '/api/v2');
expect(await page.evaluate('document.cookie')).toBe('cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie2=2');
await page.goto('https://www.example.org/api/v1'); await page.goto(server.CROSS_PROCESS_PREFIX + '/api/v1');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1');
}); });
@ -213,17 +213,17 @@ it('should throw if empty object is passed', async ({ context, page, server }) =
await context.addCookies([{ await context.addCookies([{
name: 'cookie1', name: 'cookie1',
value: '1', value: '1',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
}, },
{ {
name: 'cookie2', name: 'cookie2',
value: '2', value: '2',
domain: 'www.example.com', domain: new URL(server.PREFIX).hostname,
path: '/', path: '/',
}, },
]); ]);
await page.goto('https://www.example.com/'); await page.goto(server.PREFIX + '/');
expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie2=2'); expect(await page.evaluate('document.cookie')).toBe('cookie1=1; cookie2=2');
const error = await context.removeCookies({ }).catch(e => e); const error = await context.removeCookies({ }).catch(e => e);
expect(error.message).toContain(`Either name, domain or path are required`); expect(error.message).toContain(`Either name, domain or path are required`);