Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: disable flaky firefox tests (#1912)

Browse source
This commit is contained in:
Andrey Lushnikov 2020-04-22 00:07:02 -07:00 committed by GitHub
parent 89007c8f3d
commit 2926d33a47
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/fixtures.spec.js
View file

@ -124,7 +124,10 @@ describe('Fixtures', function() {
// TODO: ideally, we would expect the SIGKILL on the browser from // TODO: ideally, we would expect the SIGKILL on the browser from
// force kill, but that's racy with sending two signals. // force kill, but that's racy with sending two signals.
}); });
it.slow()('should kill the browser on SIGTERM + SIGINT', async state => { // TODO: flaky!
// - firefox: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607148951
// - chromium: https://travis-ci.com/github/microsoft/playwright/builds/161356178
it.slow().fail((FFOX || CHROMIUM) && LINUX)('should kill the browser on SIGTERM + SIGINT', async state => {
const result = await testSignal(state, child => { const result = await testSignal(state, child => {
process.kill(child.pid, 'SIGTERM'); process.kill(child.pid, 'SIGTERM');
process.kill(child.pid, 'SIGINT'); process.kill(child.pid, 'SIGINT');

5
test/mouse.spec.js
View file

@ -15,7 +15,7 @@
* limitations under the License. * limitations under the License.
*/ */
const {FFOX, CHROMIUM, WEBKIT, MAC} = require('./utils').testOptions(browserType); const {FFOX, CHROMIUM, WEBKIT, MAC, WIN} = require('./utils').testOptions(browserType);
function dimensions() { function dimensions() {
const rect = document.querySelector('textarea').getBoundingClientRect(); const rect = document.querySelector('textarea').getBoundingClientRect();
@ -28,7 +28,8 @@ function dimensions() {
} }
describe('Mouse', function() { describe('Mouse', function() {
it('should click the document', async({page, server}) => { // Occasionally times out on FFOX on Windows: https://github.com/microsoft/playwright/pull/1911/checks?check_run_id=607149016
it.fail(FFOX && WIN)('should click the document', async({page, server}) => {
await page.evaluate(() => { await page.evaluate(() => {
window.clickPromise = new Promise(resolve => { window.clickPromise = new Promise(resolve => {
document.addEventListener('click', event => { document.addEventListener('click', event => {