Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

cherry-pick(#17863): chore(docker): make sure failed commands exit with non-zero code (#17880)

Browse source
This commit is contained in:
Dmitry Gozman 2022-10-06 09:01:08 -07:00 committed by GitHub
parent 1bc426b94f
commit 2993281d78
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/playwright-core/src/containers/docker.ts
View file

@ -286,6 +286,7 @@ export function addDockerCLI(program: Command) {
await buildPlaywrightImage(); await buildPlaywrightImage();
} catch (e) { } catch (e) {
console.error(e.stack ? e : e.message); console.error(e.stack ? e : e.message);
process.exit(1);
} }
}); });
@ -296,6 +297,7 @@ export function addDockerCLI(program: Command) {
await startPlaywrightContainer(); await startPlaywrightContainer();
} catch (e) { } catch (e) {
console.error(e.stack ? e : e.message); console.error(e.stack ? e : e.message);
process.exit(1);
} }
}); });
@ -306,6 +308,7 @@ export function addDockerCLI(program: Command) {
await stopAllPlaywrightContainers(); await stopAllPlaywrightContainers();
} catch (e) { } catch (e) {
console.error(e.stack ? e : e.message); console.error(e.stack ? e : e.message);
process.exit(1);
} }
}); });
@ -316,11 +319,12 @@ export function addDockerCLI(program: Command) {
await deletePlaywrightImage(); await deletePlaywrightImage();
} catch (e) { } catch (e) {
console.error(e.stack ? e : e.message); console.error(e.stack ? e : e.message);
process.exit(1);
} }
}); });
dockerCommand.command('install-server-deps', { hidden: true }) dockerCommand.command('install-server-deps', { hidden: true })
.description('delete docker image, if any') .description('install run-server dependencies')
.action(async function() { .action(async function() {
const { code } = await spawnAsync('bash', [path.join(__dirname, '..', '..', 'bin', 'container_install_deps.sh')], { stdio: 'inherit' }); const { code } = await spawnAsync('bash', [path.join(__dirname, '..', '..', 'bin', 'container_install_deps.sh')], { stdio: 'inherit' });
if (code !== 0) if (code !== 0)
@ -328,7 +332,7 @@ export function addDockerCLI(program: Command) {
}); });
dockerCommand.command('run-server', { hidden: true }) dockerCommand.command('run-server', { hidden: true })
.description('delete docker image, if any') .description('run playwright server')
.action(async function() { .action(async function() {
await spawnAsync('bash', [path.join(__dirname, '..', '..', 'bin', 'container_run_server.sh')], { stdio: 'inherit' }); await spawnAsync('bash', [path.join(__dirname, '..', '..', 'bin', 'container_run_server.sh')], { stdio: 'inherit' });
}); });