From 29c3a7f0211fc6283ac40287a42b61ae932328f5 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Tue, 14 Jan 2020 13:54:48 -0800 Subject: [PATCH] test: add a failing test for Page.waitForLoadState (#488) --- test/navigation.spec.js | 10 ++++++++++ test/page.spec.js | 3 +-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/test/navigation.spec.js b/test/navigation.spec.js index 552e4648db..1712078360 100644 --- a/test/navigation.spec.js +++ b/test/navigation.spec.js @@ -758,6 +758,16 @@ module.exports.describe = function({testRunner, expect, playwright, FFOX, CHROMI response.end('Not found'); await navigationPromise; }); + it.skip(WEBKIT || FFOX)('should work with pages that have loaded before being connected to', async({page, context, server}) => { + await page.goto(server.EMPTY_PAGE); + await page.evaluate(async () => { + const child = window.open(document.location.href); + while(child.document.readyState !== 'complete' || child.document.location.href === 'about:blank') + await new Promise(setTimeout); + }); + const [, childPage] = await context.pages(); + await childPage.waitForLoadState(); + }); }); describe('Page.goBack', function() { diff --git a/test/page.spec.js b/test/page.spec.js index c7faeed706..5baedc88c4 100644 --- a/test/page.spec.js +++ b/test/page.spec.js @@ -172,8 +172,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF expect(await page.evaluate(() => !!window.opener)).toBe(false); expect(await popup.evaluate(() => !!window.opener)).toBe(false); }); - // Crashes with Target closed on WebKit / Linux. - it('should not treat navigations as new popups', async({page, server}) => { + it.skip(WEBKIT || FFOX)('should not treat navigations as new popups', async({page, server}) => { await page.goto(server.EMPTY_PAGE); await page.setContent('yo'); const [popup] = await Promise.all([