Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: send aria snapshot to the debug controller (#33969)

Browse source
This commit is contained in:
Pavel Feldman 2024-12-12 08:21:53 -08:00 committed by GitHub
parent 0e2b984287
commit 29fd2df124
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/playwright-core/src/protocol/validator.ts
View file

@ -385,6 +385,7 @@ scheme.DebugControllerInitializer = tOptional(tObject({}));
scheme.DebugControllerInspectRequestedEvent = tObject({ scheme.DebugControllerInspectRequestedEvent = tObject({
selector: tString, selector: tString,
locator: tString, locator: tString,
ariaSnapshot: tString,
}); });
scheme.DebugControllerSetModeRequestedEvent = tObject({ scheme.DebugControllerSetModeRequestedEvent = tObject({
mode: tString, mode: tString,

2
packages/playwright-core/src/server/debugController.ts
View file

@ -228,7 +228,7 @@ class InspectingRecorderApp extends EmptyRecorderApp {
override async elementPicked(elementInfo: ElementInfo): Promise<void> { override async elementPicked(elementInfo: ElementInfo): Promise<void> {
const locator: string = asLocator(this._debugController._sdkLanguage, elementInfo.selector); const locator: string = asLocator(this._debugController._sdkLanguage, elementInfo.selector);
this._debugController.emit(DebugController.Events.InspectRequested, { selector: elementInfo.selector, locator }); this._debugController.emit(DebugController.Events.InspectRequested, { selector: elementInfo.selector, locator, ariaSnapshot: elementInfo.ariaSnapshot });
} }
override async setSources(sources: Source[]): Promise<void> { override async setSources(sources: Source[]): Promise<void> {

4
packages/playwright-core/src/server/dispatchers/debugControllerDispatcher.ts
View file

@ -32,8 +32,8 @@ export class DebugControllerDispatcher extends Dispatcher<DebugController, chann
eventsHelper.addEventListener(this._object, DebugController.Events.StateChanged, params => { eventsHelper.addEventListener(this._object, DebugController.Events.StateChanged, params => {
this._dispatchEvent('stateChanged', params); this._dispatchEvent('stateChanged', params);
}), }),
eventsHelper.addEventListener(this._object, DebugController.Events.InspectRequested, ({ selector, locator }) => { eventsHelper.addEventListener(this._object, DebugController.Events.InspectRequested, ({ selector, locator, ariaSnapshot }) => {
this._dispatchEvent('inspectRequested', { selector, locator }); this._dispatchEvent('inspectRequested', { selector, locator, ariaSnapshot });
}), }),
eventsHelper.addEventListener(this._object, DebugController.Events.SourceChanged, ({ text, header, footer, actions }) => { eventsHelper.addEventListener(this._object, DebugController.Events.SourceChanged, ({ text, header, footer, actions }) => {
this._dispatchEvent('sourceChanged', ({ text, header, footer, actions })); this._dispatchEvent('sourceChanged', ({ text, header, footer, actions }));

1
packages/protocol/src/channels.ts
View file

@ -691,6 +691,7 @@ export interface DebugControllerChannel extends DebugControllerEventTarget, Chan
export type DebugControllerInspectRequestedEvent = { export type DebugControllerInspectRequestedEvent = {
selector: string, selector: string,
locator: string, locator: string,
ariaSnapshot: string,
}; };
export type DebugControllerSetModeRequestedEvent = { export type DebugControllerSetModeRequestedEvent = {
mode: string, mode: string,

1
packages/protocol/src/protocol.yml
View file

@ -807,6 +807,7 @@ DebugController:
parameters: parameters:
selector: string selector: string
locator: string locator: string
ariaSnapshot: string
setModeRequested: setModeRequested:
parameters: parameters:

2
tests/library/debug-controller.spec.ts
View file

@ -84,9 +84,11 @@ test('should pick element', async ({ backend, connectedBrowser }) => {
expect(events).toEqual([ expect(events).toEqual([
{ {
ariaSnapshot: '- button "Submit"',
selector: 'internal:role=button[name=\"Submit\"i]', selector: 'internal:role=button[name=\"Submit\"i]',
locator: 'getByRole(\'button\', { name: \'Submit\' })', locator: 'getByRole(\'button\', { name: \'Submit\' })',
}, { }, {
ariaSnapshot: '- button "Submit"',
selector: 'internal:role=button[name=\"Submit\"i]', selector: 'internal:role=button[name=\"Submit\"i]',
locator: 'getByRole(\'button\', { name: \'Submit\' })', locator: 'getByRole(\'button\', { name: \'Submit\' })',
}, },