Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

feat: roll Firefox and Firefox-Beta to latest builds (#20449)

Browse source 
These builds initiate browser-side navigation for `page.goto` command.

Drive-by: add a minimal file URL test.
This commit is contained in:
Andrey Lushnikov 2023-01-27 09:31:45 -08:00 committed by GitHub
parent 9ca9b08d90
commit 2af31edadd
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/playwright-core/browsers.json
View file

@ -21,13 +21,13 @@
}, },
{ {
"name": "firefox", "name": "firefox",
"revision": "1373", "revision": "1374",
"installByDefault": true, "installByDefault": true,
"browserVersion": "108.0.2" "browserVersion": "108.0.2"
}, },
{ {
"name": "firefox-beta", "name": "firefox-beta",
"revision": "1375", "revision": "1376",
"installByDefault": false, "installByDefault": false,
"browserVersion": "108.0b5" "browserVersion": "108.0b5"
}, },

2
packages/playwright-core/src/server/firefox/protocol.d.ts vendored
View file

@ -385,7 +385,6 @@ export module Protocol {
export type navigationStartedPayload = { export type navigationStartedPayload = {
frameId: string; frameId: string;
navigationId: string; navigationId: string;
url: string;
} }
export type navigationCommittedPayload = { export type navigationCommittedPayload = {
frameId: string; frameId: string;
@ -550,7 +549,6 @@ export module Protocol {
}; };
export type navigateReturnValue = { export type navigateReturnValue = {
navigationId: string|null; navigationId: string|null;
navigationURL: string|null;
}; };
export type goBackParameters = { export type goBackParameters = {
frameId: string; frameId: string;

13
tests/page/page-goto.spec.ts
View file

@ -28,6 +28,15 @@ it('should work @smoke', async ({ page, server }) => {
it('should work with file URL', async ({ page, asset, isAndroid }) => { it('should work with file URL', async ({ page, asset, isAndroid }) => {
it.skip(isAndroid, 'No files on Android'); it.skip(isAndroid, 'No files on Android');
const fileurl = url.pathToFileURL(asset('empty.html')).href;
await page.goto(fileurl);
expect(page.url().toLowerCase()).toBe(fileurl.toLowerCase());
expect(page.frames().length).toBe(1);
});
it('should work with file URL with subframes', async ({ page, asset, isAndroid }) => {
it.skip(isAndroid, 'No files on Android');
const fileurl = url.pathToFileURL(asset('frames/two-frames.html')).href; const fileurl = url.pathToFileURL(asset('frames/two-frames.html')).href;
await page.goto(fileurl); await page.goto(fileurl);
expect(page.url().toLowerCase()).toBe(fileurl.toLowerCase()); expect(page.url().toLowerCase()).toBe(fileurl.toLowerCase());
@ -404,10 +413,8 @@ it('should fail when replaced by another navigation', async ({ page, server, bro
await anotherPromise; await anotherPromise;
if (browserName === 'chromium') if (browserName === 'chromium')
expect(error.message).toContain('net::ERR_ABORTED'); expect(error.message).toContain('net::ERR_ABORTED');
else if (browserName === 'webkit') else if (browserName === 'webkit' || browserName === 'firefox')
expect(error.message).toContain('Navigation interrupted by another one'); expect(error.message).toContain('Navigation interrupted by another one');
else
expect(error.message).toContain('NS_BINDING_ABORTED');
}); });
it('should work when navigating to valid url', async ({ page, server }) => { it('should work when navigating to valid url', async ({ page, server }) => {