From 2b0d285a31a3e17c6a1eee648bce0f32f4b71eb5 Mon Sep 17 00:00:00 2001 From: Joel Einbinder Date: Wed, 12 Feb 2020 19:22:41 -0800 Subject: [PATCH] remove stray line --- src/browserContext.ts | 1 - test/playwright.spec.js | 11 +++++++++-- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/browserContext.ts b/src/browserContext.ts index e50ce0f270..ca56d75520 100644 --- a/src/browserContext.ts +++ b/src/browserContext.ts @@ -53,7 +53,6 @@ export class BrowserContext extends platform.EventEmitter { private readonly _delegate: BrowserContextDelegate; readonly _options: BrowserContextOptions; private _closed = false; - _captureProtocol = false; constructor(delegate: BrowserContextDelegate, options: BrowserContextOptions) { super(); diff --git a/test/playwright.spec.js b/test/playwright.spec.js index 602e83f2ec..e5365ab8fe 100644 --- a/test/playwright.spec.js +++ b/test/playwright.spec.js @@ -42,10 +42,17 @@ module.exports.describe = ({testRunner, product, playwrightPath}) => { const playwrightModule = require(playwrightPath); const playwright = playwrightModule[product.toLowerCase()]; - const headless = (process.env.HEADLESS || 'true').trim().toLowerCase() === 'true'; - const slowMo = parseInt((process.env.SLOW_MO || '0').trim(), 10); + const headless = !!valueFromEnv('HEADLESS', true); + const slowMo = valueFromEnv('SLOW_MO', 0); + const CI = valueFromEnv('CI', false); + const dumpProtocolOnFailure = CI || valueFromEnv('DEBUGP', true); let dumpProtocolOnFailure = process.env.CI || ((process.env.DEBUGP || 'false').trim().toLowerCase() === 'true'); + function valueFromEnv(name, defaultValue) { + if (!(name in process.env)) + return defaultValue; + return JSON.parse(process.env[name]); + } const executablePath = { 'Chromium': process.env.CRPATH, 'Firefox': process.env.FFPATH,