Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: mark failing headful tests as such (#2226)

Browse source
This commit is contained in:
Dmitry Gozman 2020-05-13 18:33:07 -07:00 committed by GitHub
parent a4b670464e
commit 2bca64a023
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
test/browsercontext.spec.js
View file

@ -446,7 +446,7 @@ describe('BrowserContext.route', () => {
});
describe('BrowserContext.setHTTPCredentials', function() {
it('should work', async({browser, server}) => {
it.fail(CHROMIUM && !HEADLESS)('should work', async({browser, server}) => {
server.setAuth('/empty.html', 'user', 'pass');
const context = await browser.newContext();
const page = await context.newPage();
@ -476,7 +476,7 @@ describe('BrowserContext.setHTTPCredentials', function() {
expect(response.status()).toBe(200);
await context.close();
});
it('should allow disable authentication', async({browser, server}) => {
it.fail(CHROMIUM && !HEADLESS)('should allow disable authentication', async({browser, server}) => {
server.setAuth('/empty.html', 'user', 'pass');
const context = await browser.newContext({
httpCredentials: { username: 'user', password: 'pass' }

2
test/download.spec.js
View file

@ -123,7 +123,7 @@ describe('Download', function() {
expect(fs.readFileSync(path).toString()).toBe('Hello world');
await page.close();
});
it('should report new window downloads', async({browser, server}) => {
it.fail(CHROMIUM && !HEADLESS)('should report new window downloads', async({browser, server}) => {
// TODO: - the test fails in headful Chromium as the popup page gets closed along
// with the session before download completed event arrives.
// - WebKit doesn't close the popup page

2
test/elementhandle.spec.js
View file

@ -19,7 +19,7 @@ const utils = require('./utils');
const {FFOX, CHROMIUM, WEBKIT} = require('./utils').testOptions(browserType);
describe('ElementHandle.boundingBox', function() {
it('should work', async({page, server}) => {
it.fail(FFOX && !HEADLESS)('should work', async({page, server}) => {
await page.setViewportSize({width: 500, height: 500});
await page.goto(server.PREFIX + '/grid.html');
const elementHandle = await page.$('.box:nth-of-type(13)');

2
test/fixtures.spec.js
View file

@ -73,7 +73,7 @@ describe('Fixtures', function() {
// so we don't check it here.
});
describe.skip(WIN)('signals', () => {
describe.skip(WIN).skip(!HEADLESS)('signals', () => {
// Cannot reliably send signals on Windows.
it.slow()('should report browser close signal', async state => {
const result = await testSignal(state, (child, browserPid) => process.kill(browserPid), true);

4
test/permissions.spec.js
View file

@ -85,7 +85,7 @@ describe.skip(WEBKIT)('Permissions', function() {
//TODO: flaky
// - Linux: https://github.com/microsoft/playwright/pull/1790/checks?check_run_id=587327883
// - Win: https://ci.appveyor.com/project/aslushnikov/playwright/builds/32402536
it.fail(FFOX)('should trigger permission onchange', async({page, server, context}) => {
it.fail(FFOX).fail(CHROMIUM && !HEADLESS)('should trigger permission onchange', async({page, server, context}) => {
await page.goto(server.EMPTY_PAGE);
await page.evaluate(() => {
window['events'] = [];
@ -122,7 +122,7 @@ describe.skip(WEBKIT)('Permissions', function() {
expect(await getPermission(otherPage, 'geolocation')).toBe('granted');
await otherContext.close();
});
it.skip(FFOX)('should support clipboard read', async({page, server, context, browser}) => {
it.skip(FFOX).fail(CHROMIUM && !HEADLESS)('should support clipboard read', async({page, server, context, browser}) => {
// No such permissions (requires flag) in Firefox
await page.goto(server.EMPTY_PAGE);
expect(await getPermission(page, 'clipboard-read')).toBe('prompt');