Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

make parent step ID explicit

Browse source
This commit is contained in:
Simon Knott 2024-10-18 09:34:22 +02:00
parent 0e9eaf2134
commit 2d4d402297
No known key found for this signature in database
GPG key ID: 8CEDC00028084AEC
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/playwright/src/worker/testInfo.ts
View file

@ -192,7 +192,7 @@ export class TestInfoImpl implements TestInfo {
this._attachmentsPush = this.attachments.push.bind(this.attachments); this._attachmentsPush = this.attachments.push.bind(this.attachments);
this.attachments.push = (...attachments: TestInfo['attachments']) => { this.attachments.push = (...attachments: TestInfo['attachments']) => {
for (const a of attachments) for (const a of attachments)
this._attach(a); this._attach(a, undefined);
return this.attachments.length; return this.attachments.length;
}; };
@ -292,6 +292,9 @@ export class TestInfoImpl implements TestInfo {
} }
} }
for (const attachment of result.attachments ?? [])
this._attach(attachment, stepId);
const payload: StepEndPayload = { const payload: StepEndPayload = {
testId: this.testId, testId: this.testId,
stepId, stepId,
@ -404,11 +407,10 @@ export class TestInfoImpl implements TestInfo {
category: 'attach', category: 'attach',
}); });
const attachment = await normalizeAndSaveAttachment(this.outputPath(), name, options); const attachment = await normalizeAndSaveAttachment(this.outputPath(), name, options);
this._attach(attachment);
step.complete({ attachments: [attachment] }); step.complete({ attachments: [attachment] });
} }
private _attach(attachment: TestInfo['attachments'][0]) { private _attach(attachment: TestInfo['attachments'][0], stepId: string | undefined) {
this._attachmentsPush(attachment); this._attachmentsPush(attachment);
this._onAttach({ this._onAttach({
testId: this.testId, testId: this.testId,
@ -416,7 +418,7 @@ export class TestInfoImpl implements TestInfo {
contentType: attachment.contentType, contentType: attachment.contentType,
path: attachment.path, path: attachment.path,
body: attachment.body?.toString('base64'), body: attachment.body?.toString('base64'),
stepId: this._parentStep()?.stepId, stepId,
}); });
} }