Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore(firefox): rewrite error message for $HOME directory ownership mismatch (#28921)

Browse source 
Fixes https://github.com/microsoft/playwright/issues/28896
This commit is contained in:
Max Schmitt 2024-01-09 20:40:39 +01:00 committed by GitHub
parent 4b99d21dbd
commit 2ddf3a45f9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
packages/playwright-core/src/server/firefox/firefox.ts
View file

@ -40,6 +40,9 @@ export class Firefox extends BrowserType {
_doRewriteStartupLog(error: ProtocolError): ProtocolError { _doRewriteStartupLog(error: ProtocolError): ProtocolError {
if (!error.logs) if (!error.logs)
return error; return error;
// https://github.com/microsoft/playwright/issues/6500
if (error.logs.includes(`as root in a regular user's session is not supported.`))
error.logs = '\n' + wrapInASCIIBox(`Firefox is unable to launch if the $HOME folder isn't owned by the current user.\nWorkaround: Set the HOME=/root environment variable${process.env.GITHUB_ACTION ? ' in your GitHub Actions workflow file' : ''} when running Playwright.`, 1);
if (error.logs.includes('no DISPLAY environment variable specified')) if (error.logs.includes('no DISPLAY environment variable specified'))
error.logs = '\n' + wrapInASCIIBox(kNoXServerRunningError, 1); error.logs = '\n' + wrapInASCIIBox(kNoXServerRunningError, 1);
return error; return error;