From 2e91961ab70e32e25a8206039048ac3a19355ce0 Mon Sep 17 00:00:00 2001 From: Simon Knott Date: Fri, 2 Aug 2024 12:43:53 +0200 Subject: [PATCH] fix it better --- tests/library/browsertype-connect.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/library/browsertype-connect.spec.ts b/tests/library/browsertype-connect.spec.ts index 30ba6c3fe9..1b7f646fb3 100644 --- a/tests/library/browsertype-connect.spec.ts +++ b/tests/library/browsertype-connect.spec.ts @@ -392,7 +392,7 @@ for (const kind of ['launchServer', 'run-server'] as const) { expect(pageClosed).toBeTruthy(); }); - test('should terminate network waiters', async ({ connect, startRemoteServer, server }) => { + test('should terminate network waiters', async ({ connect, startRemoteServer, server, browserName }) => { const remoteServer = await startRemoteServer(kind); const browser = await connect(remoteServer.wsEndpoint()); const newPage = await browser.newPage(); @@ -403,7 +403,7 @@ for (const kind of ['launchServer', 'run-server'] as const) { ]); for (let i = 0; i < 2; i++) { const message = results[i].message; - expect(message).toContain(kTargetClosedErrorMessage); + expect(message).toContain(browserName === 'firefox' ? 'Browser closed' : kTargetClosedErrorMessage); expect(message).not.toContain('Timeout'); } });