Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

chore: remove same-site expectations for old browsers

Browse source
This commit is contained in:
Yury Semikhatsky 2024-08-26 18:05:27 -07:00
parent 177576a51b
commit 2e96d73f52
2 changed files with 5 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tests/config/browserTest.ts
View file

@ -59,10 +59,8 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>
}, { scope: 'worker' }],
allowsThirdParty: [async ({ browserName, browserMajorVersion, channel }, run) => {
if (browserName === 'firefox' && !channel)
await run(browserMajorVersion >= 103);
else if (browserName === 'firefox' && channel === 'firefox-beta')
await run(browserMajorVersion < 103 || browserMajorVersion >= 110);
if (browserName === 'firefox')
await run(true);
else
await run(false);
}, { scope: 'worker' }],
@ -74,10 +72,8 @@ const test = baseTest.extend<BrowserTestTestFixtures, BrowserTestWorkerFixtures>
await run('Lax');
else if (browserName === 'webkit' && !isLinux)
await run('None');
else if (browserName === 'firefox' && channel === 'firefox-beta')
await run(browserMajorVersion >= 103 && browserMajorVersion < 110 ? 'Lax' : 'None');
else if (browserName === 'firefox' && channel !== 'firefox-beta')
await run(browserMajorVersion >= 103 ? 'None' : 'Lax');
else if (browserName === 'firefox')
await run('None');
else
throw new Error('unknown browser - ' + browserName);
}, { scope: 'worker' }],

7
tests/library/permissions.spec.ts
View file

@ -119,12 +119,7 @@ it.describe('permissions', () => {
await context.grantPermissions(['geolocation'], { origin: server.EMPTY_PAGE });
expect(await page.evaluate(() => window['events'])).toEqual(['prompt', 'denied', 'granted']);
await context.clearPermissions();
// Note: Chromium 110 stopped triggering "onchange" when clearing permissions.
expect(await page.evaluate(() => window['events'])).toEqual(
(browserName === 'chromium' && browserMajorVersion === 110) ?
['prompt', 'denied', 'granted'] :
['prompt', 'denied', 'granted', 'prompt']);
expect(await page.evaluate(() => window['events'])).toEqual(['prompt', 'denied', 'granted', 'prompt']);
});
it('should isolate permissions between browser contexts', async ({ server, browser }) => {