From 2f31e6373ac242479f93293fa509a38fdf7f9510 Mon Sep 17 00:00:00 2001 From: Diego Pino Date: Fri, 17 Jun 2022 23:40:58 +0800 Subject: [PATCH] devops: build WebKit for Mac using --no-use-workspace flag (#14952) Currently, Mac WebKit builds are failing in CI. It seems this is a regression in upstream WebKit as I'm able to reproduce it in my local environment. The error is the following: ``` usr/bin/codesign --force --sign - --timestamp\=none --preserve-metadata\=identifier,entitlements,flags --generate-entitlement-der /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: replacing existing signature /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: unsealed contents present in the root directory of an embedded framework Command CodeSign failed with a nonzero exit code ``` Bisecting the regression it seems the build started failing on [r295496](https://trac.webkit.org/changeset/295496/webkit) This changeset also introduced a new flag, _--no-use-workspace__, which allows to build not using WebKit.xcworkspace (I understand this is how builds were done before this changeset). Building with _--no-use-workspace_ fixes builds for Mac. --- browser_patches/webkit/build.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_patches/webkit/build.sh b/browser_patches/webkit/build.sh index 063d2c413f..dee53b66b7 100755 --- a/browser_patches/webkit/build.sh +++ b/browser_patches/webkit/build.sh @@ -53,7 +53,7 @@ fi if is_mac; then selectXcodeVersionOrDie $(node "$SCRIPT_FOLDER/../get_xcode_version.js" webkit) - ./Tools/Scripts/build-webkit --release --touch-events --orientation-events + ./Tools/Scripts/build-webkit --release --touch-events --orientation-events --no-use-workspace elif is_linux; then if [[ $# == 0 || (-z "$1") ]]; then echo