diff --git a/src/client/elementHandle.ts b/src/client/elementHandle.ts index 50a5f0622c..ec1726320e 100644 --- a/src/client/elementHandle.ts +++ b/src/client/elementHandle.ts @@ -241,10 +241,6 @@ export class ElementHandle extends JSHandle { return ElementHandle.fromNullable(result.element) as ElementHandle | null; }); } - - async _createSelectorForTest(name: string): Promise { - return (await this._elementChannel.createSelectorForTest({ name })).value; - } } export function convertSelectOptionValues(values: string | ElementHandle | SelectOption | string[] | ElementHandle[] | SelectOption[] | null): { elements?: channels.ElementHandleChannel[], options?: SelectOption[] } { diff --git a/src/dispatchers/elementHandlerDispatcher.ts b/src/dispatchers/elementHandlerDispatcher.ts index 1baddfc138..d870bcb81d 100644 --- a/src/dispatchers/elementHandlerDispatcher.ts +++ b/src/dispatchers/elementHandlerDispatcher.ts @@ -183,8 +183,4 @@ export class ElementHandleDispatcher extends JSHandleDispatcher implements chann async waitForSelector(params: channels.ElementHandleWaitForSelectorParams): Promise { return { element: ElementHandleDispatcher.createNullable(this._scope, await this._elementHandle.waitForSelector(params.selector, params)) }; } - - async createSelectorForTest(params: channels.ElementHandleCreateSelectorForTestParams): Promise { - return { value: await this._elementHandle._page.selectors._createSelector(params.name, this._elementHandle as ElementHandle) }; - } } diff --git a/src/protocol/channels.ts b/src/protocol/channels.ts index 0c000b25fd..a3f5d95acf 100644 --- a/src/protocol/channels.ts +++ b/src/protocol/channels.ts @@ -1756,7 +1756,6 @@ export interface ElementHandleChannel extends JSHandleChannel { uncheck(params: ElementHandleUncheckParams, metadata?: Metadata): Promise; waitForElementState(params: ElementHandleWaitForElementStateParams, metadata?: Metadata): Promise; waitForSelector(params: ElementHandleWaitForSelectorParams, metadata?: Metadata): Promise; - createSelectorForTest(params: ElementHandleCreateSelectorForTestParams, metadata?: Metadata): Promise; } export type ElementHandleEvalOnSelectorParams = { selector: string, @@ -2089,15 +2088,6 @@ export type ElementHandleWaitForSelectorOptions = { export type ElementHandleWaitForSelectorResult = { element?: ElementHandleChannel, }; -export type ElementHandleCreateSelectorForTestParams = { - name: string, -}; -export type ElementHandleCreateSelectorForTestOptions = { - -}; -export type ElementHandleCreateSelectorForTestResult = { - value?: string, -}; // ----------- Request ----------- export type RequestInitializer = { diff --git a/src/protocol/protocol.yml b/src/protocol/protocol.yml index 4a3cce60b3..9170cd0803 100644 --- a/src/protocol/protocol.yml +++ b/src/protocol/protocol.yml @@ -1762,12 +1762,6 @@ ElementHandle: returns: element: ElementHandle? - createSelectorForTest: - parameters: - name: string - returns: - value: string? - Request: type: interface diff --git a/src/protocol/validator.ts b/src/protocol/validator.ts index 333e4edb38..b5907a8ca8 100644 --- a/src/protocol/validator.ts +++ b/src/protocol/validator.ts @@ -837,9 +837,6 @@ export function createScheme(tChannel: (name: string) => Validator): Scheme { timeout: tOptional(tNumber), state: tOptional(tEnum(['attached', 'detached', 'visible', 'hidden'])), }); - scheme.ElementHandleCreateSelectorForTestParams = tObject({ - name: tString, - }); scheme.RequestResponseParams = tOptional(tObject({})); scheme.RouteAbortParams = tObject({ errorCode: tOptional(tString), diff --git a/src/server/selectors.ts b/src/server/selectors.ts index 88faba82b2..d700560e71 100644 --- a/src/server/selectors.ts +++ b/src/server/selectors.ts @@ -114,14 +114,6 @@ export class Selectors { return adopted; } - async _createSelector(name: string, handle: dom.ElementHandle): Promise { - const mainContext = await handle._page.mainFrame()._mainContext(); - const injectedScript = await mainContext.injectedScript(); - return injectedScript.evaluate((injected, { target, name }) => { - return injected.engines.get(name)!.create(document.documentElement, target); - }, { target: handle, name }); - } - _parseSelector(selector: string): SelectorInfo { const parsed = parseSelector(selector); for (const {name} of parsed.parts) { diff --git a/test/selectors-register.spec.ts b/test/selectors-register.spec.ts index 098eb30e61..86625cc71f 100644 --- a/test/selectors-register.spec.ts +++ b/test/selectors-register.spec.ts @@ -41,12 +41,10 @@ it('should work', async ({playwright, browser}) => { const page = await context.newPage(); await page.setContent('
'); - expect(await (await page.$('div') as any)._createSelectorForTest('tag')).toBe('DIV'); expect(await page.$eval('tag=DIV', e => e.nodeName)).toBe('DIV'); expect(await page.$eval('tag=SPAN', e => e.nodeName)).toBe('SPAN'); expect(await page.$$eval('tag=DIV', es => es.length)).toBe(2); - expect(await (await page.$('div') as any)._createSelectorForTest('tag2')).toBe('DIV'); expect(await page.$eval('tag2=DIV', e => e.nodeName)).toBe('DIV'); expect(await page.$eval('tag2=SPAN', e => e.nodeName)).toBe('SPAN'); expect(await page.$$eval('tag2=DIV', es => es.length)).toBe(2); diff --git a/test/selectors-text.spec.ts b/test/selectors-text.spec.ts index e6f85841fa..64a5c33954 100644 --- a/test/selectors-text.spec.ts +++ b/test/selectors-text.spec.ts @@ -106,22 +106,6 @@ it('query', async ({page, isWebKit}) => { expect((await page.$$(`text="lo wo"`)).length).toBe(0); }); -it('create', async ({page}) => { - await page.setContent(`
yo
"ya
ye ye
`); - expect(await (await page.$('div') as any)._createSelectorForTest('text')).toBe('yo'); - expect(await (await page.$('div:nth-child(2)') as any)._createSelectorForTest('text')).toBe('"\\"ya"'); - expect(await (await page.$('div:nth-child(3)') as any)._createSelectorForTest('text')).toBe('"ye ye"'); - - await page.setContent(`
yo
yo
ya
hey
`); - expect(await (await page.$('div:nth-child(2)') as any)._createSelectorForTest('text')).toBe('hey'); - - await page.setContent(`
yo
ya
`); - expect(await (await page.$('div') as any)._createSelectorForTest('text')).toBe('yo'); - - await page.setContent(`
"yo
ya
`); - expect(await (await page.$('div') as any)._createSelectorForTest('text')).toBe('" \\"yo "'); -}); - it('should be case sensitive if quotes are specified', async ({page}) => { await page.setContent(`
yo
ya
\nye
`); expect(await page.$eval(`text=yA`, e => e.outerHTML)).toBe('
ya
');