Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: disable flaky fixtures test (#1839)

Browse source
This commit is contained in:
Andrey Lushnikov 2020-04-16 18:46:24 -07:00 committed by GitHub
parent 31460b18b8
commit 3151ea22e3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
test/fixtures.spec.js
View file

@ -17,7 +17,7 @@
const path = require('path'); const path = require('path');
const {spawn, execSync} = require('child_process'); const {spawn, execSync} = require('child_process');
const {FFOX, CHROMIUM, WEBKIT, WIN} = require('./utils').testOptions(browserType); const {FFOX, CHROMIUM, WEBKIT, WIN, LINUX} = require('./utils').testOptions(browserType);
async function testSignal(state, action, exitOnClose) { async function testSignal(state, action, exitOnClose) {
const options = Object.assign({}, state.defaultBrowserOptions, { const options = Object.assign({}, state.defaultBrowserOptions, {
@ -123,7 +123,8 @@ describe('Fixtures', function() {
// TODO: ideally, we would expect the SIGKILL on the browser from // TODO: ideally, we would expect the SIGKILL on the browser from
// force kill, but that's racy with sending two signals. // force kill, but that's racy with sending two signals.
}); });
it.slow()('should kill the browser on SIGINT + SIGTERM', async state => { // TODO: flaky - https://app.circleci.com/pipelines/github/microsoft/playwright/582/workflows/b49033ce-fe20-4029-b665-13fb331f842e/jobs/579
it.slow().fail(FFOX && LINUX)('should kill the browser on SIGINT + SIGTERM', async state => {
const result = await testSignal(state, child => { const result = await testSignal(state, child => {
process.kill(child.pid, 'SIGINT'); process.kill(child.pid, 'SIGINT');
process.kill(child.pid, 'SIGTERM'); process.kill(child.pid, 'SIGTERM');