From 3167f2d34c41b1e10d914dec65f37b3f6def09f5 Mon Sep 17 00:00:00 2001 From: Craig Nishina Date: Tue, 14 Apr 2020 19:01:01 -0700 Subject: [PATCH] fix(chromium): prevent errors when frame does not exist when detaching from oopif (#1767) When navigating away from the page loaded in `goto`, the frame no longer exists. Page.removeFrameSession is called and throws an error. Instead of calling the helper.assert method, moved removeChildFramesRecursively into a conditional. closes #1762 --- src/chromium/crPage.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/chromium/crPage.ts b/src/chromium/crPage.ts index 2dc335ddf8..da09c67343 100644 --- a/src/chromium/crPage.ts +++ b/src/chromium/crPage.ts @@ -104,8 +104,8 @@ export class CRPage implements PageDelegate { return; // Frame id equals target id. const frame = this._page._frameManager.frame(targetId); - assert(frame); - this._page._frameManager.removeChildFramesRecursively(frame); + if (frame) + this._page._frameManager.removeChildFramesRecursively(frame); frameSession.dispose(); this._sessions.delete(targetId); }