Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Added alt+s for stopping

Browse source
This commit is contained in:
tommy-mode 2024-09-30 11:47:39 -04:00
parent ffaa08e607
commit 327a0cd25b
2 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/trace-viewer/src/ui/uiModeView.tsx
View file

@ -359,7 +359,7 @@ export const UIModeView: React.FC<{}> = ({
if (e.code === 'Backquote' && e.ctrlKey) { if (e.code === 'Backquote' && e.ctrlKey) {
e.preventDefault(); e.preventDefault();
setIsShowingOutput(!isShowingOutput); setIsShowingOutput(!isShowingOutput);
} else if (e.code === 'F5' && e.shiftKey) { } else if ((e.code === 'F5' && e.shiftKey) || (e.code === 'KeyS' && e.altKey)) {
e.preventDefault(); e.preventDefault();
testServerConnection?.stopTestsNoReply({}); testServerConnection?.stopTestsNoReply({});
} else if ((e.code === 'F5') || (e.code === 'KeyR' && e.altKey)) { } else if ((e.code === 'F5') || (e.code === 'KeyR' && e.altKey)) {

19
tests/playwright-test/ui-mode-test-shortcut.spec.ts
View file

@ -29,7 +29,7 @@ const basicTestTree = {
}; };
["F5", "Alt+r"].forEach((keyboardShortcut) => { ["F5", "Alt+r"].forEach((keyboardShortcut) => {
test.only(`should run tests with "${keyboardShortcut}"`, async ({ test(`should run tests with "${keyboardShortcut}"`, async ({
runUITest, runUITest,
}) => { }) => {
const { page } = await runUITest(basicTestTree); const { page } = await runUITest(basicTestTree);
@ -56,13 +56,16 @@ const basicTestTree = {
}); });
}); });
test('should stop tests', async ({ runUITest }) => { ["Shift+F5", "Alt+s"].forEach((keyboardShortcut) => {
test(`should stop tests with "${keyboardShortcut}"`, async ({
runUITest,
}) => {
const { page } = await runUITest(basicTestTree); const { page } = await runUITest(basicTestTree);
await expect(page.getByTitle('Run all')).toBeEnabled(); await expect(page.getByTitle("Run all")).toBeEnabled();
await expect(page.getByTitle('Stop')).toBeDisabled(); await expect(page.getByTitle("Stop")).toBeDisabled();
await page.getByTitle('Run all').click(); await page.getByTitle("Run all").click();
await expect.poll(dumpTestTree(page)).toBe(` await expect.poll(dumpTestTree(page)).toBe(`
▼ ↻ a.test.ts ▼ ↻ a.test.ts
@ -72,10 +75,10 @@ test('should stop tests', async ({ runUITest }) => {
🕦 test 3 🕦 test 3
`); `);
await expect(page.getByTitle('Run all')).toBeDisabled(); await expect(page.getByTitle("Run all")).toBeDisabled();
await expect(page.getByTitle('Stop')).toBeEnabled(); await expect(page.getByTitle("Stop")).toBeEnabled();
await page.keyboard.press('Shift+F5'); await page.keyboard.press(keyboardShortcut);
await expect.poll(dumpTestTree(page)).toBe(` await expect.poll(dumpTestTree(page)).toBe(`
▼ ◯ a.test.ts ▼ ◯ a.test.ts