Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Fix instanceof bug between execution contexts

Browse source 
First encountered at jest-playwright repo:
https://github.com/mmarkelov/jest-playwright/issues/38

Solution based on:
https://stackoverflow.com/questions/4339288/typeof-for-regexp#comment4724685_4339350
This commit is contained in:
aesyondu 2020-02-17 20:50:02 +08:00 committed by GitHub
parent e65897844f
commit 3382c56c06
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/platform.ts
View file

@ -222,7 +222,7 @@ export function urlMatches(urlString: string, match: types.URLMatch | undefined)
return true; return true;
if (helper.isString(match)) if (helper.isString(match))
match = helper.globToRegex(match); match = helper.globToRegex(match);
if (match instanceof RegExp) if (match instanceof RegExp || match.constructor.name === "RegExp")
return match.test(urlString); return match.test(urlString);
if (typeof match === 'string' && match === urlString) if (typeof match === 'string' && match === urlString)
return true; return true;