From 33852635b7f7f90cf78560b7391a64a2bd5b6235 Mon Sep 17 00:00:00 2001
From: Dmitry Gozman <dgozman@gmail.com>
Date: Tue, 24 Aug 2021 19:41:29 -0700
Subject: [PATCH] fix(fetch): skip tests on non-default modes, add node-fetch
 to deps list (#8425)

---
 packages/build_package.js          | 8 ++++++--
 tests/browsercontext-fetch.spec.ts | 2 ++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/packages/build_package.js b/packages/build_package.js
index 2f765d8935..e4fe513f7b 100755
--- a/packages/build_package.js
+++ b/packages/build_package.js
@@ -72,6 +72,7 @@ const DEPENDENCIES = [
   'https-proxy-agent',
   'jpeg-js',
   'mime',
+  'node-fetch',
   'pngjs',
   'progress',
   'proper-lockfile',
@@ -140,8 +141,11 @@ if (!args.some(arg => arg === '--no-cleanup')) {
   const pwInternalJSON = require(path.join(ROOT_PATH, 'package.json'));
   const depNames = packageName === 'playwright-test' ? Object.keys(pwInternalJSON.dependencies) : DEPENDENCIES;
   const dependencies = {};
-  for (const dep of depNames)
-    dependencies[dep] =  pwInternalJSON.dependencies[dep];
+  for (const dep of depNames) {
+    if (!pwInternalJSON.dependencies[dep])
+      throw new Error(`Dependecy ${dep} was removed from package.json, but not build_package.js`);
+    dependencies[dep] = pwInternalJSON.dependencies[dep];
+  }
   await writeToPackage('package.json', JSON.stringify({
     name: package.name || packageName,
     version: pwInternalJSON.version,
diff --git a/tests/browsercontext-fetch.spec.ts b/tests/browsercontext-fetch.spec.ts
index 21bf2a4395..248ee94954 100644
--- a/tests/browsercontext-fetch.spec.ts
+++ b/tests/browsercontext-fetch.spec.ts
@@ -17,6 +17,8 @@
 import http from 'http';
 import { contextTest as it, expect } from './config/browserTest';
 
+it.skip(({ mode }) => mode !== 'default');
+
 let prevAgent: http.Agent;
 it.beforeAll(() => {
   prevAgent = http.globalAgent;