From 33bbb15e30f0deaf65f7581b94330932bd79530a Mon Sep 17 00:00:00 2001 From: wodyjowski Date: Fri, 30 Sep 2022 09:41:03 +0200 Subject: [PATCH] fix: grid connection invalid method (#17706) This patch fixes invalid method (GET instead of POST) used when connecting to Selenium Grid by http with proxy. Fixes #17707 --- packages/playwright-core/src/common/netUtils.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/packages/playwright-core/src/common/netUtils.ts b/packages/playwright-core/src/common/netUtils.ts index 4cfca7c69f..4092ab1385 100644 --- a/packages/playwright-core/src/common/netUtils.ts +++ b/packages/playwright-core/src/common/netUtils.ts @@ -50,15 +50,16 @@ export function httpRequest(params: HTTPRequestParams, onResponse: (r: http.Inco const proxyURL = getProxyForUrl(params.url); if (proxyURL) { + const parsedProxyURL = URL.parse(proxyURL); if (params.url.startsWith('http:')) { - const proxy = URL.parse(proxyURL); options = { path: parsedUrl.href, - host: proxy.hostname, - port: proxy.port, + host: parsedProxyURL.hostname, + port: parsedProxyURL.port, + headers: options.headers, + method: options.method }; } else { - const parsedProxyURL = URL.parse(proxyURL); (parsedProxyURL as any).secureProxy = parsedProxyURL.protocol === 'https:'; options.agent = new HttpsProxyAgent(parsedProxyURL);