Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

review feedback

Browse source
This commit is contained in:
Max Schmitt 2024-10-28 21:29:39 +01:00
parent f7bbc5259c
commit 3422d7c32f
6 changed files with 12 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/src/test-api/class-testinfoerror.md
View file

@ -8,7 +8,7 @@ Information about an error thrown during test execution.
* since: v1.49
- type: ?<[TestInfoError]>
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
## property: TestInfoError.message
* since: v1.10

2
docs/src/test-reporter-api/class-testerror.md
View file

@ -8,7 +8,7 @@ Information about an error thrown during test execution.
* since: v1.49
- type: ?<[TestError]>
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
## property: TestError.message
* since: v1.10

6
packages/playwright/src/reporters/base.ts
View file

@ -441,10 +441,8 @@ export function formatError(error: TestError, highlightCode: boolean): ErrorDeta
if (parsedStack && !location)
location = parsedStack.location;
if (error.cause) {
tokens.push();
tokens.push(indent(colors.dim('[cause]: ') + formatError(error.cause, highlightCode).message, ' '));
}
if (error.cause)
tokens.push(colors.dim('[cause]: ') + formatError(error.cause, highlightCode).message);
return {
location,

2
packages/playwright/types/test.d.ts vendored
View file

@ -9155,7 +9155,7 @@ export interface TestInfoError {
/**
* Error cause. Set when there is a
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
* error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
* error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
*/
cause?: TestInfoError;

2
packages/playwright/types/testReporter.d.ts vendored
View file

@ -557,7 +557,7 @@ export interface TestError {
/**
* Error cause. Set when there is a
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
* error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
* error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
*/
cause?: TestError;

12
tests/playwright-test/reporter-base.spec.ts
View file

@ -156,12 +156,12 @@ for (const useIntermediateMergeReport of [false, true] as const) {
expect(result.failed).toBe(1);
const testFile = path.join(result.report.config.rootDir, result.report.suites[0].specs[0].file);
expect(result.output).toContain(` at ${testFile}:18:21`);
expect(result.output).toContain(` [cause]: Error: outer-message`);
expect(result.output).toContain(` at ${testFile}:14:25`);
expect(result.output).toContain(` [cause]: Error: inner-message`);
expect(result.output).toContain(` at ${testFile}:12:25`);
expect(result.output).toContain(` [cause]: SpecialError: my-message`);
expect(result.output).toContain(` at ${testFile}:7:31`);
expect(result.output).toContain(` [cause]: Error: outer-message`);
expect(result.output).toContain(` at ${testFile}:14:25`);
expect(result.output).toContain(` [cause]: Error: inner-message`);
expect(result.output).toContain(` at ${testFile}:12:25`);
expect(result.output).toContain(` [cause]: SpecialError: my-message`);
expect(result.output).toContain(` at ${testFile}:7:31`);
expect(result.output).toContain('afterAll executed successfully');
});