review feedback
This commit is contained in:
parent
f7bbc5259c
commit
3422d7c32f
|
|
@ -8,7 +8,7 @@ Information about an error thrown during test execution.
|
||||||
* since: v1.49
|
* since: v1.49
|
||||||
- type: ?<[TestInfoError]>
|
- type: ?<[TestInfoError]>
|
||||||
|
|
||||||
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
|
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
|
||||||
|
|
||||||
## property: TestInfoError.message
|
## property: TestInfoError.message
|
||||||
* since: v1.10
|
* since: v1.10
|
||||||
|
|
|
||||||
|
|
@ -8,7 +8,7 @@ Information about an error thrown during test execution.
|
||||||
* since: v1.49
|
* since: v1.49
|
||||||
- type: ?<[TestError]>
|
- type: ?<[TestError]>
|
||||||
|
|
||||||
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
|
Error cause. Set when there is a [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
|
||||||
|
|
||||||
## property: TestError.message
|
## property: TestError.message
|
||||||
* since: v1.10
|
* since: v1.10
|
||||||
|
|
|
||||||
|
|
@ -441,10 +441,8 @@ export function formatError(error: TestError, highlightCode: boolean): ErrorDeta
|
||||||
if (parsedStack && !location)
|
if (parsedStack && !location)
|
||||||
location = parsedStack.location;
|
location = parsedStack.location;
|
||||||
|
|
||||||
if (error.cause) {
|
if (error.cause)
|
||||||
tokens.push();
|
tokens.push(colors.dim('[cause]: ') + formatError(error.cause, highlightCode).message);
|
||||||
tokens.push(indent(colors.dim('[cause]: ') + formatError(error.cause, highlightCode).message, ' '));
|
|
||||||
}
|
|
||||||
|
|
||||||
return {
|
return {
|
||||||
location,
|
location,
|
||||||
|
|
|
||||||
2
packages/playwright/types/test.d.ts
vendored
2
packages/playwright/types/test.d.ts
vendored
|
|
@ -9155,7 +9155,7 @@ export interface TestInfoError {
|
||||||
/**
|
/**
|
||||||
* Error cause. Set when there is a
|
* Error cause. Set when there is a
|
||||||
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
|
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
|
||||||
* error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
|
* error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
|
||||||
*/
|
*/
|
||||||
cause?: TestInfoError;
|
cause?: TestInfoError;
|
||||||
|
|
||||||
|
|
|
||||||
2
packages/playwright/types/testReporter.d.ts
vendored
2
packages/playwright/types/testReporter.d.ts
vendored
|
|
@ -557,7 +557,7 @@ export interface TestError {
|
||||||
/**
|
/**
|
||||||
* Error cause. Set when there is a
|
* Error cause. Set when there is a
|
||||||
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
|
* [cause](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause) for the
|
||||||
* error. Will be null if there is no cause or if the cause is not an instance of [Error] (or its subclass).
|
* error. Will be `undefined` if there is no cause or if the cause is not an instance of [Error]
|
||||||
*/
|
*/
|
||||||
cause?: TestError;
|
cause?: TestError;
|
||||||
|
|
||||||
|
|
|
||||||
|
|
@ -156,12 +156,12 @@ for (const useIntermediateMergeReport of [false, true] as const) {
|
||||||
expect(result.failed).toBe(1);
|
expect(result.failed).toBe(1);
|
||||||
const testFile = path.join(result.report.config.rootDir, result.report.suites[0].specs[0].file);
|
const testFile = path.join(result.report.config.rootDir, result.report.suites[0].specs[0].file);
|
||||||
expect(result.output).toContain(` at ${testFile}:18:21`);
|
expect(result.output).toContain(` at ${testFile}:18:21`);
|
||||||
expect(result.output).toContain(` [cause]: Error: outer-message`);
|
expect(result.output).toContain(` [cause]: Error: outer-message`);
|
||||||
expect(result.output).toContain(` at ${testFile}:14:25`);
|
expect(result.output).toContain(` at ${testFile}:14:25`);
|
||||||
expect(result.output).toContain(` [cause]: Error: inner-message`);
|
expect(result.output).toContain(` [cause]: Error: inner-message`);
|
||||||
expect(result.output).toContain(` at ${testFile}:12:25`);
|
expect(result.output).toContain(` at ${testFile}:12:25`);
|
||||||
expect(result.output).toContain(` [cause]: SpecialError: my-message`);
|
expect(result.output).toContain(` [cause]: SpecialError: my-message`);
|
||||||
expect(result.output).toContain(` at ${testFile}:7:31`);
|
expect(result.output).toContain(` at ${testFile}:7:31`);
|
||||||
expect(result.output).toContain('afterAll executed successfully');
|
expect(result.output).toContain('afterAll executed successfully');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue