Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

review feedback

Browse source
This commit is contained in:
Max Schmitt 2024-04-19 19:59:01 +02:00
parent 02e3df9cd0
commit 35151a835d
6 changed files with 36 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.github/workflows/publish_release_docker.yml vendored
View file

@ -22,7 +22,7 @@ jobs:
id-token: write # This is required for OIDC login (azure/login) to succeed id-token: write # This is required for OIDC login (azure/login) to succeed
contents: read # This is required for actions/checkout to succeed contents: read # This is required for actions/checkout to succeed
if: github.repository == 'microsoft/playwright' if: github.repository == 'microsoft/playwright'
environment: Docker environment: allow-publishing-docker-to-acr
steps: steps:
- name: Azure Login - name: Azure Login
uses: azure/login@v2 uses: azure/login@v2

1
.github/workflows/tests_electron.yml vendored
View file

@ -21,6 +21,7 @@ env:
jobs: jobs:
test_electron: test_electron:
name: ${{ matrix.os }} name: ${{ matrix.os }}
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:

4
.github/workflows/tests_primary.yml vendored
View file

@ -27,6 +27,7 @@ env:
jobs: jobs:
test_linux: test_linux:
name: ${{ matrix.os }} (${{ matrix.browser }} - Node.js ${{ matrix.node-version }}) name: ${{ matrix.os }} (${{ matrix.browser }} - Node.js ${{ matrix.node-version }})
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -78,6 +79,7 @@ jobs:
test_linux_chromium_tot: test_linux_chromium_tot:
name: ${{ matrix.os }} (chromium tip-of-tree) name: ${{ matrix.os }} (chromium tip-of-tree)
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -122,6 +124,7 @@ jobs:
test_test_runner: test_test_runner:
name: Test Runner name: Test Runner
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -256,6 +259,7 @@ jobs:
test_package_installations: test_package_installations:
name: "Installation Test ${{ matrix.os }}" name: "Installation Test ${{ matrix.os }}"
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:

28
.github/workflows/tests_secondary.yml vendored
View file

@ -26,6 +26,7 @@ permissions:
jobs: jobs:
test_linux: test_linux:
name: ${{ matrix.os }} (${{ matrix.browser }}) name: ${{ matrix.os }} (${{ matrix.browser }})
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -66,6 +67,7 @@ jobs:
test_mac: test_mac:
name: ${{ matrix.os }} (${{ matrix.browser }}) name: ${{ matrix.os }} (${{ matrix.browser }})
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -105,6 +107,7 @@ jobs:
test_win: test_win:
name: "Windows" name: "Windows"
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -148,6 +151,7 @@ jobs:
test-package-installations-other-node-versions: test-package-installations-other-node-versions:
name: "Installation Test ${{ matrix.os }} (${{ matrix.node_version }})" name: "Installation Test ${{ matrix.os }} (${{ matrix.node_version }})"
environment: allow-uploading-flakiness-results
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
strategy: strategy:
fail-fast: false fail-fast: false
@ -187,6 +191,7 @@ jobs:
headed_tests: headed_tests:
name: "headed ${{ matrix.browser }} (${{ matrix.os }})" name: "headed ${{ matrix.browser }} (${{ matrix.os }})"
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -229,6 +234,7 @@ jobs:
transport_linux: transport_linux:
name: "Transport" name: "Transport"
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -269,6 +275,7 @@ jobs:
tracing_linux: tracing_linux:
name: Tracing ${{ matrix.browser }} ${{ matrix.channel }} name: Tracing ${{ matrix.browser }} ${{ matrix.channel }}
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
@ -315,6 +322,7 @@ jobs:
chrome_stable_linux: chrome_stable_linux:
name: "Chrome Stable (Linux)" name: "Chrome Stable (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "chrome-stable-linux" PWTEST_BOT_NAME: "chrome-stable-linux"
@ -350,6 +358,7 @@ jobs:
chrome_stable_win: chrome_stable_win:
name: "Chrome Stable (Win)" name: "Chrome Stable (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "chrome-stable-windows" PWTEST_BOT_NAME: "chrome-stable-windows"
@ -386,6 +395,7 @@ jobs:
chrome_stable_mac: chrome_stable_mac:
name: "Chrome Stable (Mac)" name: "Chrome Stable (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "chrome-stable-mac" PWTEST_BOT_NAME: "chrome-stable-mac"
@ -421,6 +431,7 @@ jobs:
chromium_tot: chromium_tot:
name: Chromium TOT ${{ matrix.os }} name: Chromium TOT ${{ matrix.os }}
environment: allow-uploading-flakiness-results
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
env: env:
PWTEST_CHANNEL: chromium-tip-of-tree PWTEST_CHANNEL: chromium-tip-of-tree
@ -462,6 +473,7 @@ jobs:
chromium_tot_headed: chromium_tot_headed:
name: Chromium TOT headed ${{ matrix.os }} name: Chromium TOT headed ${{ matrix.os }}
environment: allow-uploading-flakiness-results
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
env: env:
PWTEST_CHANNEL: chromium-tip-of-tree PWTEST_CHANNEL: chromium-tip-of-tree
@ -503,6 +515,7 @@ jobs:
firefox_beta_linux: firefox_beta_linux:
name: "Firefox Beta (Linux)" name: "Firefox Beta (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "firefox-beta-linux" PWTEST_BOT_NAME: "firefox-beta-linux"
@ -538,6 +551,7 @@ jobs:
firefox_beta_win: firefox_beta_win:
name: "Firefox Beta (Win)" name: "Firefox Beta (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "firefox-beta-windows" PWTEST_BOT_NAME: "firefox-beta-windows"
@ -574,6 +588,7 @@ jobs:
firefox_beta_mac: firefox_beta_mac:
name: "Firefox Beta (Mac)" name: "Firefox Beta (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "firefox-beta-mac" PWTEST_BOT_NAME: "firefox-beta-mac"
@ -609,6 +624,7 @@ jobs:
edge_stable_mac: edge_stable_mac:
name: "Edge Stable (Mac)" name: "Edge Stable (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "edge-stable-mac" PWTEST_BOT_NAME: "edge-stable-mac"
@ -644,6 +660,7 @@ jobs:
edge_stable_win: edge_stable_win:
name: "Edge Stable (Win)" name: "Edge Stable (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "edge-stable-windows" PWTEST_BOT_NAME: "edge-stable-windows"
@ -680,6 +697,7 @@ jobs:
edge_stable_linux: edge_stable_linux:
name: "Edge Stable (Linux)" name: "Edge Stable (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "edge-stable-linux" PWTEST_BOT_NAME: "edge-stable-linux"
@ -715,6 +733,7 @@ jobs:
edge_beta_mac: edge_beta_mac:
name: "Edge Beta (Mac)" name: "Edge Beta (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "edge-beta-mac" PWTEST_BOT_NAME: "edge-beta-mac"
@ -750,6 +769,7 @@ jobs:
edge_beta_win: edge_beta_win:
name: "Edge Beta (Win)" name: "Edge Beta (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "edge-beta-windows" PWTEST_BOT_NAME: "edge-beta-windows"
@ -786,6 +806,7 @@ jobs:
edge_beta_linux: edge_beta_linux:
name: "Edge Beta (Linux)" name: "Edge Beta (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "edge-beta-linux" PWTEST_BOT_NAME: "edge-beta-linux"
@ -821,6 +842,7 @@ jobs:
edge_dev_mac: edge_dev_mac:
name: "Edge Dev (Mac)" name: "Edge Dev (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "edge-dev-mac" PWTEST_BOT_NAME: "edge-dev-mac"
@ -856,6 +878,7 @@ jobs:
edge_dev_win: edge_dev_win:
name: "Edge Dev (Win)" name: "Edge Dev (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "edge-dev-windows" PWTEST_BOT_NAME: "edge-dev-windows"
@ -892,6 +915,7 @@ jobs:
edge_dev_linux: edge_dev_linux:
name: "Edge Dev (Linux)" name: "Edge Dev (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "edge-dev-linux" PWTEST_BOT_NAME: "edge-dev-linux"
@ -927,6 +951,7 @@ jobs:
chrome_beta_linux: chrome_beta_linux:
name: "Chrome Beta (Linux)" name: "Chrome Beta (Linux)"
environment: allow-uploading-flakiness-results
runs-on: ubuntu-20.04 runs-on: ubuntu-20.04
env: env:
PWTEST_BOT_NAME: "chrome-beta-linux" PWTEST_BOT_NAME: "chrome-beta-linux"
@ -962,6 +987,7 @@ jobs:
chrome_beta_win: chrome_beta_win:
name: "Chrome Beta (Win)" name: "Chrome Beta (Win)"
environment: allow-uploading-flakiness-results
runs-on: windows-latest runs-on: windows-latest
env: env:
PWTEST_BOT_NAME: "chrome-beta-windows" PWTEST_BOT_NAME: "chrome-beta-windows"
@ -998,6 +1024,7 @@ jobs:
chrome_beta_mac: chrome_beta_mac:
name: "Chrome Beta (Mac)" name: "Chrome Beta (Mac)"
environment: allow-uploading-flakiness-results
runs-on: macos-latest runs-on: macos-latest
env: env:
PWTEST_BOT_NAME: "chrome-beta-mac" PWTEST_BOT_NAME: "chrome-beta-mac"
@ -1046,6 +1073,7 @@ jobs:
test_linux_chromium_headless_new: test_linux_chromium_headless_new:
name: Linux Chromium Headless New name: Linux Chromium Headless New
environment: allow-uploading-flakiness-results
runs-on: ubuntu-latest runs-on: ubuntu-latest
env: env:
PWTEST_BOT_NAME: "headless-new" PWTEST_BOT_NAME: "headless-new"

1
.github/workflows/tests_video.yml vendored
View file

@ -14,6 +14,7 @@ env:
jobs: jobs:
video_linux: video_linux:
name: "Video Linux" name: "Video Linux"
environment: allow-uploading-flakiness-results
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:

1
.github/workflows/tests_webview2.yml vendored
View file

@ -22,6 +22,7 @@ env:
jobs: jobs:
test_webview2: test_webview2:
name: WebView2 name: WebView2
environment: allow-uploading-flakiness-results
runs-on: windows-2022 runs-on: windows-2022
permissions: permissions:
id-token: write # This is required for OIDC login (azure/login) to succeed id-token: write # This is required for OIDC login (azure/login) to succeed