Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

test: use net8.0 for webview2 tests (#28665)

Browse source
This commit is contained in:
Max Schmitt 2023-12-15 13:03:33 -08:00 committed by GitHub
parent 86ef7393ba
commit 35b61b7cdf
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/tests_webview2.yml vendored
View file

@ -29,9 +29,9 @@ jobs:
- uses: actions/setup-node@v3 - uses: actions/setup-node@v3
with: with:
node-version: 18 node-version: 18
- uses: actions/setup-dotnet@v2 - uses: actions/setup-dotnet@v3
with: with:
dotnet-version: '6.0.x' dotnet-version: '8.0.x'
- run: npm ci - run: npm ci
env: env:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1 PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1

2
tests/webview2/globalSetup.ts
View file

@ -19,7 +19,7 @@ import playwright from 'playwright';
export default async () => { export default async () => {
const cdpPort = 9876; const cdpPort = 9876;
const spawnedProcess = childProcess.spawn(path.join(__dirname, 'webview2-app/bin/Debug/net6.0-windows/webview2.exe'), { const spawnedProcess = childProcess.spawn(path.join(__dirname, 'webview2-app/bin/Debug/net8.0-windows/webview2.exe'), {
shell: true, shell: true,
env: { env: {
...process.env, ...process.env,

2
tests/webview2/webView2Test.ts
View file

@ -35,7 +35,7 @@ export const webView2Test = baseTest.extend<TraceViewerFixtures>(traceViewerFixt
browser: [async ({ playwright }, use, testInfo) => { browser: [async ({ playwright }, use, testInfo) => {
const cdpPort = 10000 + testInfo.workerIndex; const cdpPort = 10000 + testInfo.workerIndex;
const spawnedProcess = new TestChildProcess({ const spawnedProcess = new TestChildProcess({
command: [path.join(__dirname, 'webview2-app/bin/Debug/net6.0-windows/webview2.exe')], command: [path.join(__dirname, 'webview2-app/bin/Debug/net8.0-windows/webview2.exe')],
shell: true, shell: true,
env: { env: {
...process.env, ...process.env,

4
tests/webview2/webview2-app/webview2.csproj
View file

@ -2,14 +2,14 @@
<PropertyGroup> <PropertyGroup>
<OutputType>WinExe</OutputType> <OutputType>WinExe</OutputType>
<TargetFramework>net6.0-windows</TargetFramework> <TargetFramework>net8.0-windows</TargetFramework>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<UseWindowsForms>true</UseWindowsForms> <UseWindowsForms>true</UseWindowsForms>
<ImplicitUsings>enable</ImplicitUsings> <ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>
<PackageReference Include="Microsoft.Web.WebView2" Version="1.0.1293.44" /> <PackageReference Include="Microsoft.Web.WebView2" Version="1.0.2210.55" />
</ItemGroup> </ItemGroup>
</Project> </Project>