Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(list mode): print errors to stderr (#13016)

Browse source 
`--list` mode now prints any errors encountered during test collection,
for example syntax errors, to `stderr`.
This commit is contained in:
Dmitry Gozman 2022-03-24 07:33:33 -07:00 committed by GitHub
parent 174225697a
commit 3688e74e3e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 21 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/playwright-test/src/runner.ts
View file

@ -25,6 +25,7 @@ import { TestCase, Suite } from './test';
import { Loader } from './loader';
import { FullResult, Reporter, TestError } from '../types/testReporter';
import { Multiplexer } from './reporters/multiplexer';
import { formatError } from './reporters/base';
import DotReporter from './reporters/dot';
import GitHubReporter from './reporters/github';
import LineReporter from './reporters/line';
@ -684,7 +685,10 @@ function createTestGroups(rootSuite: Suite): TestGroup[] {
}
class ListModeReporter implements Reporter {
private config!: FullConfig;
onBegin(config: FullConfig, suite: Suite): void {
this.config = config;
// eslint-disable-next-line no-console
console.log(`Listing tests:`);
const tests = suite.allTests();
@ -701,6 +705,11 @@ class ListModeReporter implements Reporter {
// eslint-disable-next-line no-console
console.log(`Total: ${tests.length} ${tests.length === 1 ? 'test' : 'tests'} in ${files.size} ${files.size === 1 ? 'file' : 'files'}`);
}
onError(error: TestError) {
// eslint-disable-next-line no-console
console.error('\n' + formatError(this.config, error, false).message);
}
}
function createForbidOnlyError(config: FullConfig, onlyTestsAndSuites: (TestCase | Suite)[]): TestError {

13
tests/playwright-test/list-mode.spec.ts
View file

@ -14,7 +14,7 @@
* limitations under the License.
*/
import { test, expect } from './playwright-test-fixtures';
import { test, expect, stripAnsi } from './playwright-test-fixtures';
import path from 'path';
import fs from 'fs';
@ -140,3 +140,14 @@ test('outputDir should not be removed', async ({ runInlineTest }, testInfo) => {
expect(result2.exitCode).toBe(0);
expect(fs.existsSync(path.join(outputDir, 'a-my-test', 'myfile.txt'))).toBe(true);
});
test('should report errors', async ({ runInlineTest }) => {
const result = await runInlineTest({
'a.test.js': `
const oh = '';
oh = 2;
`
}, { 'list': true });
expect(result.exitCode).toBe(1);
expect(stripAnsi(result.output)).toContain('> 6 | oh = 2;');
});