Filip/playwright
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

fix(ct): respect boolean shorthands (#14798)

Browse source
This commit is contained in:
Pavel Feldman 2022-06-10 16:34:21 -08:00 committed by GitHub
parent 5617e5c613
commit 380e787065
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 27 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/playwright-test/src/transform.ts
View file

@ -26,7 +26,7 @@ import { tsConfigLoader } from './third_party/tsconfig-loader';
import Module from 'module'; import Module from 'module';
import type { BabelTransformFunction } from './babelBundle'; import type { BabelTransformFunction } from './babelBundle';
const version = 11; const version = 12;
const cacheDir = process.env.PWTEST_CACHE_DIR || path.join(os.tmpdir(), 'playwright-transform-cache'); const cacheDir = process.env.PWTEST_CACHE_DIR || path.join(os.tmpdir(), 'playwright-transform-cache');
const sourceMaps: Map<string, string> = new Map(); const sourceMaps: Map<string, string> = new Map();

2
packages/playwright-test/src/tsxTransform.ts
View file

@ -91,6 +91,8 @@ export default declare((api: BabelAPI) => {
props.push(t.objectProperty(t.stringLiteral(attrName), jsxAttribute.value)); props.push(t.objectProperty(t.stringLiteral(attrName), jsxAttribute.value));
else if (t.isJSXExpressionContainer(jsxAttribute.value) && t.isExpression(jsxAttribute.value.expression)) else if (t.isJSXExpressionContainer(jsxAttribute.value) && t.isExpression(jsxAttribute.value.expression))
props.push(t.objectProperty(t.stringLiteral(attrName), jsxAttribute.value.expression)); props.push(t.objectProperty(t.stringLiteral(attrName), jsxAttribute.value.expression));
else if (jsxAttribute.value === null)
props.push(t.objectProperty(t.stringLiteral(attrName), t.booleanLiteral(true)));
else else
props.push(t.objectProperty(t.stringLiteral(attrName), t.nullLiteral())); props.push(t.objectProperty(t.stringLiteral(attrName), t.nullLiteral()));
} else if (t.isJSXSpreadAttribute(jsxAttribute)) { } else if (t.isJSXSpreadAttribute(jsxAttribute)) {

24
tests/playwright-test/playwright.ct-react.spec.ts
View file

@ -297,3 +297,27 @@ test('should return root locator for fragments', async ({ runInlineTest }) => {
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1); expect(result.passed).toBe(1);
}); });
test('should respect default property values', async ({ runInlineTest }) => {
const result = await runInlineTest({
'playwright/index.html': `<script type="module" src="/playwright/index.ts"></script>`,
'playwright/index.ts': `//@no-header`,
'src/label.tsx': `//@no-header
export const Label = ({ checked }) => <div>type:{typeof checked} value:{String(checked)}</div>;
`,
'src/label.test.tsx': `
//@no-header
import { test, expect } from '@playwright/experimental-ct-react';
import { Label } from './label';
test('boolean shorthand', async ({ mount }) => {
const component = await mount(<Label checked></Label>);
await expect(component).toHaveText('type:boolean value:true');
});
`,
}, { workers: 1 });
expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1);
});