From 38b5f76d6e431413fe78029d6af3848955409833 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Tue, 28 Jan 2020 11:27:14 -0800 Subject: [PATCH] fix(test): wait for load state before checking opener of popup (#714) --- test/page.spec.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/page.spec.js b/test/page.spec.js index b6b515c2e7..3672e78c23 100644 --- a/test/page.spec.js +++ b/test/page.spec.js @@ -143,7 +143,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF await page.goto(server.EMPTY_PAGE); await page.setContent('yo'); const [popup] = await Promise.all([ - new Promise(x => page.once('popup', x)), + page.waitForEvent('popup').then(async popup => { await popup.waitForLoadState(); return popup; }), page.click('a'), ]); expect(await page.evaluate(() => !!window.opener)).toBe(false);